Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #54, #55 -- check payload type before trimming #59

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Refs #54, #55 -- check payload type before trimming #59

merged 4 commits into from
Oct 23, 2023

Conversation

amureki
Copy link
Member

@amureki amureki commented Sep 25, 2023

No description provided.

@amureki amureki added the bug Something isn't working label Sep 25, 2023
@amureki amureki self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2926d0c) 99.72% compared to head (1d231c1) 99.72%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          10       10           
  Lines         368      370    +2     
=======================================
+ Hits          367      369    +2     
  Misses          1        1
Files Coverage Δ
emark/backends.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codingjoe
codingjoe reviewed Sep 25, 2023
View reviewed changes
emark/backends.py Outdated Show resolved Hide resolved
tests/test_backends.py Outdated Show resolved Hide resolved
codingjoe
codingjoe approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just move two lines for better performance and renamed an import that caught my attention during the review.

@amureki
Copy link
Member Author

amureki commented Oct 23, 2023

I just move two lines for better performance and renamed an import that caught my attention during the review.

lol, makes total sense, thanks, Johannes 👍

@amureki amureki merged commit e5ea0d8 into main Oct 23, 2023
15 checks passed
@amureki amureki deleted the console-backend-payload branch October 23, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingjoe codingjoe codingjoe approved these changes

Assignees

@amureki amureki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amureki @codingjoe