Skip to content

Commit

Permalink
Merge pull request #362 from hzxuzhonghu/cleanup
Browse files Browse the repository at this point in the history
Some cleanups after kube-batch intree
  • Loading branch information
volcano-sh-bot authored Jul 20, 2019
2 parents ad46a6e + 4f8b1b7 commit 7770147
Show file tree
Hide file tree
Showing 31 changed files with 12 additions and 2,584 deletions.
16 changes: 0 additions & 16 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ required = [
branch = "master"
name = "github.com/golang/glog"

[[constraint]]
name = "github.com/kubernetes-sigs/kube-batch"
branch = "master"
source = "https://github.com/volcano-sh/scheduler"

[[constraint]]
name = "github.com/onsi/ginkgo"
version = "1.7.0"
Expand All @@ -61,10 +56,6 @@ required = [
name = "k8s.io/client-go"
version = "10.0.0"

[[constraint]]
branch = "master"
name = "k8s.io/gengo"

[[constraint]]
name = "k8s.io/kubernetes"
version = "1.13.2"
Expand Down
2 changes: 1 addition & 1 deletion docs/samples/kubecon-2019-china/scripts/node-info.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"fmt"
v1 "k8s.io/api/core/v1"

"github.com/kubernetes-sigs/kube-batch/pkg/scheduler/api"
"volcano.sh/volcano/pkg/scheduler/api"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
Expand Down
2 changes: 1 addition & 1 deletion hack/generate-yaml.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ fi
cat ${VK_ROOT}/installer/namespace.yaml > ${DEPLOYMENT_FILE}
${HELM_BIN_DIR}/helm template ${VK_ROOT}/installer/helm/chart/volcano --namespace volcano-system \
--name volcano --set basic.image_tag_version=${VOLCANO_IMAGE_TAG} \
--set basic.scheduler_config_file=kube-batch-ci.conf \
--set basic.scheduler_config_file=volcano-scheduler.conf \
-x templates/admission.yaml \
-x templates/batch_v1alpha1_job.yaml \
-x templates/bus_v1alpha1_command.yaml \
Expand Down
1 change: 0 additions & 1 deletion hack/lib/golang.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# limitations under the License.

# The golang package that we are building.
readonly KUBE_GO_PACKAGE=github.com/kubernetes-sigs/kube-batch
readonly KUBE_GOPATH="${GOPATH}"

# The set of server targets that we are only building for Linux
Expand Down
4 changes: 2 additions & 2 deletions hack/run-e2e-kind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function install-volcano {
kind load docker-image ${MPI_EXAMPLE_IMAGE} ${CLUSTER_CONTEXT}

echo "Install volcano chart"
helm install installer/helm/chart/volcano --namespace kube-system --name ${CLUSTER_NAME} --kubeconfig ${KUBECONFIG} --set basic.image_tag_version=${TAG} --set basic.scheduler_config_file=kube-batch-ci.conf --wait
helm install installer/helm/chart/volcano --namespace kube-system --name ${CLUSTER_NAME} --kubeconfig ${KUBECONFIG} --set basic.image_tag_version=${TAG} --set basic.scheduler_config_file=volcano-scheduler-ci.conf --wait
}

function uninstall-volcano {
Expand All @@ -51,7 +51,7 @@ function generate-log {
echo "Generating volcano log files"
kubectl logs deployment/${CLUSTER_NAME}-admission -n kube-system > volcano-admission.log
kubectl logs deployment/${CLUSTER_NAME}-controllers -n kube-system > volcano-controller.log
kubectl logs deployment/${CLUSTER_NAME}-scheduler -n kube-system > volcano-kube-batch.log
kubectl logs deployment/${CLUSTER_NAME}-scheduler -n kube-system > volcano-scheduler.log

}

Expand Down
2 changes: 1 addition & 1 deletion installer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ The following are the list configurable parameters of Volcano Chart and their de
|`basic.scheduler_image_name`|Scheduler Docker Image Name|`volcanosh/vc-scheduler`|
|`basic.admission_image_name`|Admission Controller Image Name|`volcanosh/vc-admission`|
|`basic.admission_secret_name`|Volcano Admission Secret Name|`volcano-admission-secret`|
|`basic.scheduler_config_file`|Configuration File name for Scheduler|`kube-batch.conf`|
|`basic.scheduler_config_file`|Configuration File name for Scheduler|`volcano-scheduler.conf`|
|`basic.image_pull_secret`|Image Pull Secret|`""`|
|`basic.image_pull_policy`|Image Pull Policy|`IfNotPresent`|
|`basic.admission_app_name`|Admission Controller App Name|`volcano-admission`|
Expand Down
2 changes: 1 addition & 1 deletion installer/helm/chart/volcano/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ basic:
scheduler_image_name: "volcanosh/vc-scheduler"
admission_image_name: "volcanosh/vc-admission"
admission_secret_name: "volcano-admission-secret"
scheduler_config_file: "kube-batch.conf"
scheduler_config_file: "volcano-scheduler.conf"
image_pull_secret: ""
6 changes: 3 additions & 3 deletions installer/volcano-development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
name: volcano-scheduler-configmap
namespace: volcano-system
data:
kube-batch-ci.conf: |
volcano-scheduler-ci.conf: |
actions: "enqueue, reclaim, allocate, backfill, preempt"
tiers:
- plugins:
Expand All @@ -22,7 +22,7 @@ data:
- name: predicates
- name: proportion
- name: nodeorder
kube-batch.conf: |
volcano-scheduler.conf: |
actions: "enqueue, allocate, backfill"
tiers:
- plugins:
Expand Down Expand Up @@ -140,7 +140,7 @@ spec:
image: volcanosh/vc-scheduler:latest
args:
- --alsologtostderr
- --scheduler-conf=/volcano.scheduler/kube-batch-ci.conf
- --scheduler-conf=/volcano.scheduler/volcano-scheduler-ci.conf
- -v=3
- 2>&1
imagePullPolicy: "IfNotPresent"
Expand Down
2 changes: 1 addition & 1 deletion pkg/admission/admit_job.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
"volcano.sh/volcano/pkg/controllers/job/plugins"
)

//KubeBatchClientSet is kube-batch clientset
// KubeBatchClientSet is volcano clientset
var KubeBatchClientSet versioned.Interface

// AdmitJobs is to admit jobs and return response
Expand Down
2 changes: 1 addition & 1 deletion pkg/admission/admit_job_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ func TestValidateExecution(t *testing.T) {
Weight: 1,
},
}
// create fake kube-batch clientset
// create fake volcano clientset
KubeBatchClientSet = kubebatchclient.NewSimpleClientset()

//create default queue
Expand Down
2 changes: 1 addition & 1 deletion pkg/scheduler/cache/event_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func isTerminated(status kbapi.TaskStatus) bool {
}

// getOrCreateJob will return corresponding Job for pi if it exists, or it will create a Job and return it if
// pi.Pod.Spec.SchedulerName is same as kube-batch scheduler's name, otherwise it will return nil.
// pi.Pod.Spec.SchedulerName is same as volcano scheduler's name, otherwise it will return nil.
func (sc *SchedulerCache) getOrCreateJob(pi *kbapi.TaskInfo) *kbapi.JobInfo {
if len(pi.Job) == 0 {
if pi.Pod.Spec.SchedulerName != sc.schedulerName {
Expand Down
201 changes: 0 additions & 201 deletions vendor/github.com/kubernetes-sigs/kube-batch/LICENSE

This file was deleted.

This file was deleted.

Loading

0 comments on commit 7770147

Please sign in to comment.