Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanups after kube-batch intree #362

Merged
merged 6 commits into from
Jul 20, 2019
Merged

Some cleanups after kube-batch intree #362

merged 6 commits into from
Jul 20, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 19, 2019
@hzxuzhonghu
Copy link
Collaborator Author

/cc @TommyLike

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7081a840-aa03-11e9-91b1-f106ceecf692

@TommyLike
Copy link
Contributor

TommyLike commented Jul 19, 2019 •
edited
Loading

@hzxuzhonghu scheduler config file is used to generate the configmap yaml. Therefore we can't delete them all.

@hzxuzhonghu
Copy link
Collaborator Author

I remember i renamed it, will have a look

@hzxuzhonghu
Copy link
Collaborator Author

Added back

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 16121d90-aa12-11e9-91b1-f106ceecf692

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 14758490-aa12-11e9-91b1-f106ceecf692

@k82cn
Copy link
Member

k82cn commented Jul 19, 2019

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@TommyLike
Copy link
Contributor

/retest

@TommyLike
Copy link
Contributor

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 7770147 into volcano-sh:master Jul 20, 2019
@hzxuzhonghu hzxuzhonghu deleted the cleanup branch July 20, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

@TommyLike TommyLike Awaiting requested review from TommyLike

Assignees

@TommyLike TommyLike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hzxuzhonghu @TravisBuddy @TommyLike @k82cn @volcano-sh-bot