generate-yaml volcano-monitoring-latest.yaml diffrent

[lengrongfu]

Description

When i change chart file, then exec make generate-yaml TAG=latest RELEASE_DIR=installer command, every time volcano-monitoring-latest.yaml this file will change, remove the following code.

volcano/installer/volcano-monitoring-latest.yaml

Lines 449 to 450 in 8d05ea0

	nodeSelector:
	node.kubernetes.io/instance-type: controlpanel

because $kube_state_metrics_ns this var is not value.

volcano/installer/helm/chart/volcano/templates/kubestatemetrics.yaml

Lines 188 to 190 in 8d05ea0

	{{ if $kube_state_metrics_ns }}
	nodeSelector: {{- toYaml $kube_state_metrics_ns | nindent 8 }}
	{{ end }}

volcano/installer/helm/chart/volcano/templates/kubestatemetrics.yaml

Line 2 in 8d05ea0

{{ $kube_state_metrics_ns := or .Values.custom.kube_state_metrics_ns .Values.custom.default_ns }}

I found in values.yaml file not define value for this two var .Values.custom.kube_state_metrics_ns and .Values.custom.default_ns.

I can't trace the history.

Can someone tell me how I should modify it? is change volcano-monitoring-latest.yaml this file or and node select to values.yaml?

Steps to reproduce the issue

Describe the results you received and expected

Hope exec make generate-yaml TAG=latest RELEASE_DIR=installer this command, no other changes will occur.

What version of Volcano are you using?

master

Any other relevant information

No response

[lengrongfu]

/good-first-issue

[volcano-sh-bot]

@lengrongfu:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lengrongfu]

/assign

[fengruotj]

@volcano-sh-bot I am very interested in this issue, please assign it to me. Maybe, we can remove the nodeSelector default value from the volcano/installer/volcano-monitoring-latest.yaml file.

[Monokaix]

caused by #3740

[fengruotj]

@lengrongfu @Monokaix Hi all, maybe we can remove the default nodeSelector value from the volcano monitoring installation yaml.