Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded nodeSelector for kubestatematrics #3740

Conversation

lekaf974
Copy link
Contributor

Fix #3735

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2024
@lekaf974 lekaf974 force-pushed the feat/kubestatemetrics-remove-haedcoded-nodeselector branch from f949c1c to d8ff6b8 Compare September 23, 2024 11:33
@Monokaix
Copy link
Member

Please also update installer/README.md for new added option.

Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974 lekaf974 force-pushed the feat/kubestatemetrics-remove-haedcoded-nodeselector branch from d8ff6b8 to 011ffa3 Compare September 24, 2024 16:38
@lekaf974
Copy link
Contributor Author

Please also update installer/README.md for new added option.

Done

@Monokaix
Copy link
Member

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@volcano-sh-bot volcano-sh-bot merged commit d670451 into volcano-sh:master Sep 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart - remove hard coded nodeSelector for kubestatemetrics portion
3 participants