Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint error #2801

Merged
merged 1 commit into from
Apr 22, 2023
Merged

fix: lint error #2801

merged 1 commit into from
Apr 22, 2023

Conversation

lowang-bh
Copy link
Member

resolve lint error

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2023
@wangyang0616
Copy link
Member

associate: #2806

@wangyang0616
Copy link
Member

/priority high

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2023
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's GLTM to me. Please rebase the latest master branch to the patch. Thanks!

Signed-off-by: lowang_bh <lhui_wang@163.com>
@lowang-bh
Copy link
Member Author

It's GLTM to me. Please rebase the latest master branch to the patch. Thanks!

Have rebased.

Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2023
@volcano-sh-bot volcano-sh-bot merged commit 58bd8ef into volcano-sh:master Apr 22, 2023
@lowang-bh lowang-bh deleted the fixLintError branch May 27, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/high size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants