Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)set minimal Java version to (again) be 8 instead of 11 (fixes #142) #209

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

vorburger
Copy link
Owner

This should fix #142.

@mosesn @duttonw @thomasbao12 LGTY?

@vorburger
Copy link
Owner Author

Duh! While this worked locally, as-is it fails on CI, twice, for Java 8 due to: Unrecognized option: --add-exports

and on Java 21 due to: source value 8 is obsolete and will be removed in a future release

@vorburger vorburger force-pushed the java8 branch 3 times, most recently from a9d355d to cc83e65 Compare June 16, 2024 21:33
@vorburger
Copy link
Owner Author

for Java 8 due to: Unrecognized option: --add-exports

I figured out that this is because of https://errorprone.info/docs/installation, hear hear:

Please note that Error Prone must be run on JDK 11 or newer. (It can still be used to build Java 8 code by setting the appropriate -source / -target / -bootclasspath flags.)

Ergo, the GH CI Action matrix build cannot run under Java 8, but only Java 11+ ... but we can and are still using source/target/release 8 instead 11 in the pom.xml; I've done the needful, and this seems to work.

and on Java 21 due to: source value 8 is obsolete and will be removed in a future release

I figured out that this can be fixed with javac option -Xlint:all,-options; I've done the needful, and this seems to work.

@vorburger vorburger merged commit 9a9c2bc into main Jun 16, 2024
9 checks passed
@vorburger vorburger deleted the java8 branch June 16, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.5 targets java 8 but calls a java 9 method
1 participant