add parsing of string version list of sample ids in _parse_sample_ids

[nebulae]

What changes are proposed in this pull request?

added check & conversion for comma delimited string of sample ids in _parse_sample_ids

How is this patch tested? If it is not, please explain why.

locally & with unit test

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

[codecov]

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (c386456) 15.87% compared to head (c83df70) 15.86%.
Report is 3 commits behind head on develop.

Files	Patch %	Lines
...ore/src/components/Schema/SchemaSelectControls.tsx	0.00%	45 Missing ⚠️
app/packages/core/src/utils/links.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3940      +/-   ##
===========================================
- Coverage    15.87%   15.86%   -0.01%     
===========================================
  Files          731      731              
  Lines        81640    81665      +25     
  Branches      1093     1093              
===========================================
  Hits         12959    12959              
- Misses       68681    68706      +25     

Flag	Coverage Δ
app	15.86% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brimoor]

I don't believe we've publicly documented anywhere that you can pass a comma-separated string list of IDs to Select(). Where did you encounter that?

[nebulae]

it was a bug reported - TEAMS-2062 - the app passes it in as a comma delimited string in some scenarios via the viewbar, as a list of strings in other scenarios. Seemed the right place to fix it rather than identify all the places it could be used as input.

[brimoor]

I see. Actually this line:

fiftyone/fiftyone/core/stages.py

Line 5648 in ad17d5e

"type": "list<id>|id",

is supposed to tell the App to parse "list,of,str" into ["list", "of", "str"], so it seems that is no longer working in certain cases? Or some new pathway for view stage parsing was added (didn't look at the ticket) that wasn't aware that it needed to support the type=list<> parameter definition.

cc @benjaminpkane can you help track down the root cause?

The type=list<> syntax is used in other view stages too, so I think that is actually the best place to fix the string parsing inconsistency.

[benjaminpkane]

I've included a view bar fix in #3941 with c45be8a as it also contains ObjectId client-side validation

[brimoor]

Closing as the issue has been resolved by #3940 (comment).