-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning bug fixes #3941
Lightning bug fixes #3941
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.3 #3941 +/- ##
================================================
Coverage 15.92% 15.92%
================================================
Files 732 732
Lines 81926 81947 +21
Branches 1093 1093
================================================
+ Hits 13045 13051 +6
- Misses 68881 68896 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a3f9df7
to
d0662d7
Compare
c45be8a
to
1d150da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!!
export const cleanCSV = (values: string) => { | ||
return ( | ||
values | ||
// replace spaces with a single space (to allow search by words with spaces) | ||
.replace(/[\s\'\"\[\]]+/g, " ") | ||
// replace comma followed by trailing spaces with a single comma | ||
.replace(/,\s*/g, ",") | ||
// remove trailing spaces | ||
.replace(/[ \t]+$/, "") | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Fixes two
id
field bugs related to lightning modeChanges
id
field is enabled in lightning mode by looking up the schema db path in thepathIndexes
selectorObjectId
field searches in the sidebarRelated e2e tests have been added for verification
Screen.Recording.2023-12-18.at.3.29.12.PM.mov