Lightning bug fixes #3941
Merged
Lightning bug fixes #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.3 #3941 +/- ##
================================================
Coverage 15.92% 15.92%
================================================
Files 732 732
Lines 81926 81947 +21
Branches 1093 1093
================================================
+ Hits 13045 13051 +6
- Misses 68881 68896 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benjaminpkane
force-pushed
the
lightning-e2e
branch
from
a3f9df7
to
d0662d7
Compare
7 tasks
benjaminpkane
force-pushed
the
lightning-e2e
branch
from
c45be8a
to
1d150da
Compare
benjaminpkane
changed the base branch from
release-notes/v0.23.3
to
release/v0.23.3
sashankaryal
approved these changes
Jan 16, 2024
Comment on lines
+25
to
+35
| export const cleanCSV = (values: string) => { | ||
| return ( | ||
| values | ||
| // replace spaces with a single space (to allow search by words with spaces) | ||
| .replace(/[\s\'\"\[\]]+/g, " ") | ||
| // replace comma followed by trailing spaces with a single comma | ||
| .replace(/,\s*/g, ",") | ||
| // remove trailing spaces | ||
| .replace(/[ \t]+$/, "") | ||
| ); | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two
idfield bugs related to lightning modeChanges
idfield is enabled in lightning mode by looking up the schema db path in thepathIndexesselectorObjectIdfield searches in the sidebarRelated e2e tests have been added for verification
Screen.Recording.2023-12-18.at.3.29.12.PM.mov