Fix dependency problems with APT repo handling #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first issue was that Exec[apt_get_update_for_nginx] resource is only needed if $manage_repo == true, so it was put inside the corresponding if block. But even inside the if-block, Exec[apt_get_update_for_nginx] could fail when $package_source has an invalid value and no Apt::Source[nginx] is defined, so the respective Apt::Source[nginx], if defined, will now notify Exec[apt_get_update_for_nginx] and Exec[apt_get_update_for_nginx] will no longer subscribe to Apt::Source[nginx]. It would probably make sense to add a call to fail() in the default case of $package_source.
jfryman
pushed a commit
that referenced
this pull request
Oct 9, 2013
Fix dependency problems with APT repo handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first issue was that
Exec[apt_get_update_for_nginx]resource is only needed if$manage_repo == true, so it was put inside the corresponding if block.But even inside the if-block,
Exec[apt_get_update_for_nginx]could fail when$package_sourcehas an invalid value and noApt::Source[nginx]is defined, so the respectiveApt::Source[nginx], if defined, will now notifyExec[apt_get_update_for_nginx]andExec[apt_get_update_for_nginx]will no longer subscribe toApt::Source[nginx].It would probably make sense to add a call to fail() in the default case of
$package_source.