Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency problems with APT repo handling #155

Merged
merged 1 commit into from
Oct 9, 2013

Commits on Oct 9, 2013

  1. Fix dependency problems with APT repo handling

    The first issue was that Exec[apt_get_update_for_nginx] resource is only
    needed if $manage_repo == true, so it was put inside the corresponding
    if block.
    
    But even inside the if-block, Exec[apt_get_update_for_nginx] could fail
    when $package_source has an invalid value and no Apt::Source[nginx] is
    defined, so the respective Apt::Source[nginx], if defined, will now notify
    Exec[apt_get_update_for_nginx] and Exec[apt_get_update_for_nginx] will
    no longer subscribe to Apt::Source[nginx].
    
    It would probably make sense to add a call to fail() in the default case
    of $package_source.
    fpletz committed Oct 9, 2013
    Configuration menu
    Copy the full SHA
    3edc7ad View commit details
    Browse the repository at this point in the history