Fix use of include_files in nginx::resource::map
#1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite already provide optional parameter values for each test that rely on them, so we do not need to pass them to all tests. Moreover, some on these changed default values prevent the test suite from failing because of a regression introduced when refactoring maps. Remove the default values to trigger the test suite breakage and allow checking that a fix is working as expected.
Only attempt to compute the longest key of mappings when mappings are actually passed.
jay7x
approved these changes
Sep 10, 2024
smortex
changed the title
include_files in nginx::resource::mapinclude_files in nginx::resource::map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing some
include_filesbut nomappings, catalog compilation fail with the following error message:Refactoring done in #1575 has introduced this regression.