Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of include_files in nginx::resource::map #1613

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix use of include_files in nginx::resource::map #1613

merged 2 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Only provide default values for required parameters 

    The test suite already provide optional parameter values for each test
that rely on them, so we do not need to pass them to all tests.

Moreover, some on these changed default values prevent the test suite
from failing because of a regression introduced when refactoring maps.

Remove the default values to trigger the test suite breakage and allow
checking that a fix is working as expected.
    @smortex
    smortex committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1deae36 View commit details
    Browse the repository at this point in the history

  2. Fix catalog compilation when no mappings are passed 

    Only attempt to compute the longest key of mappings when mappings are
actually passed.
    @smortex
    smortex committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    04dd721 View commit details
    Browse the repository at this point in the history