Raise warning if hiera check is called but disabled #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
approved these changes
Mar 8, 2024
Previously we got the following output from the `syntax` rake task: ```terminal $ bundle exec rake syntax ---> syntax:manifests ---> syntax:templates ---> syntax:hiera:yaml ``` This is a bit misleading because the `syntax:hiera:yaml` task was indeed called, but it doesn't do anything because `PuppetSyntax.check_hiera_keys` was false. With this commit the output changes: ```terminal $ bundle exec rake syntax---> syntax:manifests ---> syntax:templates ---> syntax:hiera:yaml syntax:hiera:yaml was called, but PuppetSyntax.check_hiera_keys is false. hiera syntax won't be checked ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we got the following output from the
syntaxrake task:This is a bit misleading because the
syntax:hiera:yamltask was indeed called, but it doesn't do anything becausePuppetSyntax.check_hiera_keyswas false. With this commit the output changes: