AAB build and sign support for Android, compile constants support and other improvements #41

inikityuk · 2022-06-11T06:44:33Z

Hey @voydz,

Had a bit of time recently to update your plugin. Major changes are:

Android: added ability to build AAB files (including signing)
Android: added support to projects with multiple AndroidManifest files (handy if your build configuration using different ones)
Android: added "key-password" signing property (handy if "store password" doesn't match with "key password")
Android/iOS: added support for compile constants (handy if you using them as switches in projects)
iOS: added ability to specify provisioning profile to sign with
Updated readme with most common properties and basic usage

NOTE:
this PR will resolve few open issues:
#34
#33

Happy to keep it updated for some time if any new issues come up.

…figuration we building

Added addition check for "keystore_password" before trying to sign apk

…manifest_files Making sure we getting AndroidManifest file location exactly from con…

…ed_no_need_to_sign_with_default_keypass Removed double signing of apk file

Added key-pass support Changed naming for signed APK and AAB files (name will be affected, not an extension)

…tically

Added AAB build support

…le to sign with Added "build_platform" property validation

…ecify_provisioning_profile_to_sign_with Added "provision_profile_uuid" property to specify provisioning profi…

Updated github readme

added ability to create .xcarchive on build for iOS

inikityuk · 2022-08-16T07:13:14Z

Feels like "souyuz" is not supporting this repo, I'm going to create separate plugin for fastlane with current modifications.
For anyone looking to build Xamarin apps for Android (APK or AAB) or iOS can fork or pull all new changes from "inikityuk"

Updated readme

voydz

Hey @inikityuk ,

thank you very much for your time and effort. I checked your changes and got some proposals and change requests. Your opinion is appreciated.

voydz · 2022-08-16T07:17:14Z

README.md

@@ -4,6 +4,18 @@ A fastlane component to make Xamarin builds a breeze. Souyuz is now avaialbe as

 *NOTE: While souyuz should continue working with your existing configuration just fine, consider using the Fastlane plugin.*

+# inikityuk 16/08/2022


Could you please extract this portion to a CHANGELOG.md file?

voydz · 2022-08-16T07:21:25Z

lib/souyuz/detect_values.rb

+      configuration = Souyuz.config[:build_configuration]
+      platform = Souyuz.config[:build_platform]
+
+      doc_node = doc_csproj.xpath("/*[local-name()='Project']/*[local-name()='PropertyGroup'][translate(@*[local-name() = 'Condition'],'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz') = \" '$(configuration)|$(platform)' == '#{configuration.downcase}|#{platform.downcase}' \"]/*[local-name()='AndroidManifest']/text()")


Can this be cleaned up a bit?
It looks like it is somewhat similar to Lines 172 in the same file.

voydz · 2022-08-16T07:21:54Z

lib/souyuz/detect_values.rb

+      configuration = Souyuz.config[:build_configuration]
+      platform = Souyuz.config[:build_platform]
+
+      compile_constants_node = doc_csproj.xpath("/*[local-name()='Project']/*[local-name()='PropertyGroup'][translate(@*[local-name() = 'Condition'],'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz') = \" '$(configuration)|$(platform)' == '#{configuration.downcase}|#{platform.downcase}' \"]/*[local-name()='DefineConstants']/text()")


same as above

voydz · 2022-08-16T07:22:02Z

lib/souyuz/detect_values.rb

+      configuration = Souyuz.config[:build_configuration]
+      platform = Souyuz.config[:build_platform]
+
+      android_package_format_node = doc_csproj.xpath("/*[local-name()='Project']/*[local-name()='PropertyGroup'][translate(@*[local-name() = 'Condition'],'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz') = \" '$(configuration)|$(platform)' == '#{configuration.downcase}|#{platform.downcase}' \"]/*[local-name()='AndroidPackageFormat']/text()")


same as above

voydz · 2022-08-16T07:23:41Z

lib/souyuz/generators/build_command_generator.rb

@@ -44,7 +45,8 @@ def build_targets
      def targets
        targets = []
        targets += build_targets
-        targets << "-t:SignAndroidPackage" if Souyuz.project.android?
+        targets << "-t:SignAndroidPackage" if Souyuz.project.android? and !Souyuz.config[:keystore_path] and !Souyuz.config[:keystore_alias] and !Souyuz.config[:keystore_password]


Could you group those conditions to a helper method for better readability, please?

voydz · 2022-08-16T07:26:36Z

lib/souyuz/options.rb

@@ -2,6 +2,10 @@

 module Souyuz
  class Options
+
+    PROVISION_FILES_DEFAULT_LOCATION = "#{Dir.home}/Library/MobileDevice/Provisioning\ Profiles/".freeze


What do you think of this: Allow the user not to specify a provisioning profile UUID but the whole path to it. You give the user more flexibility if the profile is downloaded to the project folder for example.
Therefore we can safe us from hardcoding paths which are prone to change in future buildchain versions.

voydz · 2022-08-16T07:29:03Z

lib/souyuz/runner.rb

+
+        # Set provisioning profile
+        if config[:provision_profile_uuid]
+          provision_profile_default_path = "#{Dir.home}/Library/MobileDevice/Provisioning\ Profiles/".freeze


See provisioning profile proposal above.

voydz · 2022-08-16T07:31:08Z

lib/souyuz/runner.rb

+
+          xml = doc.to_xml
+          UI.command_output(xml) if $verbose
+          File.write(Souyuz.config[:project_path], xml)


I think it should be noted for the user, that using this function will change the project file. That could be an issue for some CI setups. So I think its best to make the user aware of that.

voydz · 2022-08-16T07:31:22Z

lib/souyuz/runner.rb

+
+          xml = doc.to_xml
+          UI.command_output(xml) if $verbose
+          File.write(Souyuz.config[:project_path], xml)


I think it should be noted for the user, that using this function will change the project file. That could be an issue for some CI setups. So I think its best to make the user aware of that.

Updated zipalign - Android Updated signing - Android

Feature/net6 build support update

Updated APK signing process to use latest build-tools

Update JDK version selection

i-nikityuk and others added 16 commits May 25, 2022 13:27

Making sure we getting AndroidManifest file location exactly from con…

3bd6061

…figuration we building

Removed double signing of apk file

3fa3928

Added addition check for "keystore_password" before trying to sign apk

Merge pull request #1 from inikityuk/bugfix/add_support_for_multiple_…

771c0cb

…manifest_files Making sure we getting AndroidManifest file location exactly from con…

Merge pull request #2 from inikityuk/bugfix/if_signing_details_provid…

9baee4d

…ed_no_need_to_sign_with_default_keypass Removed double signing of apk file

Added AAB build support

5b5c6d2

Added key-pass support Changed naming for signed APK and AAB files (name will be affected, not an extension)

Update readme with new "key-password" option

7123e42

Removed "compile_constants" from options - it will be detected automa…

c4bc7b4

…tically

Added fallback for missing 'AndroidManifest' tag in project file

1a2de2f

Merge pull request #3 from inikityuk/feature/android_aab_build_support

1b403ff

Added AAB build support

Added "provision_profile_uuid" property to specify provisioning profi…

19771c5

…le to sign with Added "build_platform" property validation

Updated readme

51b599f

Merge pull request #4 from inikityuk/feature/ios_added_property_to_sp…

2f0c4e0

…ecify_provisioning_profile_to_sign_with Added "provision_profile_uuid" property to specify provisioning profi…

Updated github readme

f81d752

Merge pull request #5 from inikityuk/feature/update_github_readme

790ce9b

Updated github readme

added ability to create .xcarchive on build for iOS

d2663f8

Merge pull request #6 from inikityuk/feature/archive_on_build_support

f8a0cfd

added ability to create .xcarchive on build for iOS

inikityuk closed this Aug 16, 2022

voydz reopened this Aug 16, 2022

i-nikityuk and others added 2 commits August 16, 2022 17:25

Updated readme

a0db094

Merge pull request #7 from inikityuk/feature/archive_on_build_support

d9efc23

Updated readme

voydz requested changes Aug 16, 2022

View reviewed changes

i-nikityuk and others added 5 commits August 28, 2023 06:29

Updated build command to match VS

e5cf1d1

Updated zipalign - Android Updated signing - Android

Updated plugin to support NET 6-7 projects

fa8c0d9

Clean up

2b8d700

Updated README

59712a4

Merge pull request #8 from inikityuk/feature/NET6_build_support_update

1147922

Feature/net6 build support update

voydz mentioned this pull request Sep 13, 2023

How to sign aab Android packages #34

Open

i-nikityuk and others added 2 commits June 13, 2024 14:15

Update JDK version selection

4bf1f3e

Updated APK signing process to use latest build-tools

Merge pull request #9 from inikityuk/feature/NET6_build_support_update

90b7706

Update JDK version selection

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AAB build and sign support for Android, compile constants support and other improvements #41

AAB build and sign support for Android, compile constants support and other improvements #41

inikityuk commented Jun 11, 2022

inikityuk commented Aug 16, 2022 •

edited

Loading

voydz left a comment

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

voydz Aug 16, 2022

		@@ -4,6 +4,18 @@ A fastlane component to make Xamarin builds a breeze. Souyuz is now avaialbe as

		NOTE: While souyuz should continue working with your existing configuration just fine, consider using the Fastlane plugin.

		# inikityuk 16/08/2022

AAB build and sign support for Android, compile constants support and other improvements #41

Are you sure you want to change the base?

AAB build and sign support for Android, compile constants support and other improvements #41

Conversation

inikityuk commented Jun 11, 2022

inikityuk commented Aug 16, 2022 • edited Loading

voydz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

inikityuk commented Aug 16, 2022 •

edited

Loading