Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove BFNT #173

Merged
merged 1 commit into from
Nov 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,6 @@ source_group(saturation_source_files FILES ${VAMPIRE_SATURATION_SOURCES})
set(VAMPIRE_SHELL_SOURCES
Shell/AnswerExtractor.cpp
#Shell/AxiomGenerator.cpp
Shell/BFNT.cpp
Shell/BFNTMainLoop.cpp
Shell/CommandLine.cpp
Shell/CNF.cpp
Shell/NewCNF.cpp
Expand Down Expand Up @@ -579,8 +577,6 @@ set(VAMPIRE_SHELL_SOURCES
#Shell/SubsumptionRemover.cpp
Shell/AnswerExtractor.hpp
#Shell/AxiomGenerator.hpp
Shell/BFNT.hpp
Shell/BFNTMainLoop.hpp
Shell/CommandLine.hpp
Shell/CNF.hpp
Shell/NewCNF.hpp
Expand Down
4 changes: 0 additions & 4 deletions FMB/ClauseFlattening.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ bool ClauseFlattening::isShallow(Literal* lit)
* Apply equality resolution to all negative equalities between variables
* in cl and return the result. If cl contains no such inequalities, return cl
* itself.
*
* Copied from BFNT, put here in case we remove BFNT
*/
Clause* ClauseFlattening::resolveNegativeVariableEqualities(Clause* cl)
{
Expand Down Expand Up @@ -126,8 +124,6 @@ Clause* ClauseFlattening::resolveNegativeVariableEqualities(Clause* cl)
/**
* Flatten clauses
*
* Largely based on BFNT::apply
*
* @author Giles
*/
Clause* ClauseFlattening::flatten(Clause* cl)
Expand Down
6 changes: 0 additions & 6 deletions Kernel/Inference.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -853,12 +853,6 @@ vstring Kernel::ruleName(InferenceRule rule)
return "external";
case InferenceRule::CLAIM_DEFINITION:
return "claim definition";
case InferenceRule::BFNT_FLATTENING:
return "bfnt flattening";
case InferenceRule::BFNT_DISTINCT:
return "bfnt distinct";
case InferenceRule::BFNT_TOTALITY:
return "bfnt totality";
case InferenceRule::FMB_FLATTENING:
return "flattening (finite model building)";
case InferenceRule::FMB_FUNC_DEF:
Expand Down
9 changes: 1 addition & 8 deletions Kernel/Inference.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -329,13 +329,6 @@ enum class InferenceRule : unsigned char {
/** inference coming from outside of Vampire */
EXTERNAL,

/** BNFT flattening */
BFNT_FLATTENING,
/** BNFT axioms m != n */
BFNT_DISTINCT,
/** BNFT totality axioms R(x,1) \/ ... \/ R(x,n) */
BFNT_TOTALITY,

/* FMB flattening */
FMB_FLATTENING,
/* Functional definition for FMB */
Expand Down Expand Up @@ -745,7 +738,7 @@ class Inference
* - integer/rational/real theory axioms are internal theory axioms
* - term algebra axioms are internal theory axioms
* - FOOL axioms are internal theory axioms
* - equality-proxy-axioms, SimplifyProver’s-distinct-number-axioms, and BFNT-axioms
* - equality-proxy-axioms
* are not treated as internal theory axioms, since they are not generated in TheoryAxioms
* (these axioms should probably be refactored into TheoryAxioms at some point)
* - consequences of theory axioms are not theory axioms
Expand Down
5 changes: 0 additions & 5 deletions Kernel/MainLoop.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@

#include "SAT/Z3MainLoop.hpp"

#include "Shell/BFNTMainLoop.hpp"
#include "Shell/Options.hpp"
#include "Shell/UIHelper.hpp"

Expand Down Expand Up @@ -111,10 +110,6 @@ MainLoop* MainLoop::createFromOptions(Problem& prb, const Options& opt)
{
CALL("MainLoop::createFromOptions");

if(opt.bfnt()) {
return new BFNTMainLoop(prb, opt);
}

#if VZ3
bool isComplete = false; // artificially prevent smtForGround from running

Expand Down
2 changes: 1 addition & 1 deletion Kernel/Signature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ void Signature::Symbol::addToDistinctGroup(unsigned group,unsigned this_number)
env.signature->_distinctGroupsAddedTo=true;

Signature::DistinctGroupMembers members = env.signature->_distinctGroupMembers[group];
if(members->size() <= DistinctGroupExpansion::EXPAND_UP_TO_SIZE || env.options->bfnt()
if(members->size() <= DistinctGroupExpansion::EXPAND_UP_TO_SIZE
|| env.options->saturationAlgorithm()==Options::SaturationAlgorithm::FINITE_MODEL_BUILDING){
// we add one more than EXPAND_UP_TO_SIZE to signal to DistinctGroupExpansion::apply not to expand
// ... instead DistinctEqualitySimplifier will take over
Expand Down
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,6 @@ VST_OBJ= Saturation/AWPassiveClauseContainer.o\
Saturation/ManCSPassiveClauseContainer.o\

VS_OBJ = Shell/AnswerExtractor.o\
Shell/BFNT.o\
Shell/BFNTMainLoop.o\
Shell/CommandLine.o\
Shell/CNF.o\
Shell/NewCNF.o\
Expand Down Expand Up @@ -532,7 +530,7 @@ VAMP_DIRS := Api Debug DP Lib Lib/Sys Kernel FMB Indexing Inferences InstGen She

VAMP_BASIC := $(MINISAT_OBJ) $(VD_OBJ) $(VL_OBJ) $(VLS_OBJ) $(VK_OBJ) $(BP_VD_OBJ) $(BP_VL_OBJ) $(BP_VLS_OBJ) $(BP_VSOL_OBJ) $(BP_VT_OBJ) $(BP_MPS_OBJ) $(ALG_OBJ) $(VI_OBJ) $(VINF_OBJ) $(VIG_OBJ) $(VSAT_OBJ) $(DP_OBJ) $(VST_OBJ) $(VS_OBJ) $(PARSE_OBJ) $(VFMB_OBJ)
#VCLAUSIFY_BASIC := $(VD_OBJ) $(VL_OBJ) $(VLS_OBJ) $(VK_OBJ) $(ALG_OBJ) $(VI_OBJ) $(VINF_OBJ) $(VSAT_OBJ) $(VST_OBJ) $(VS_OBJ) $(VT_OBJ)
VCLAUSIFY_BASIC := $(VD_OBJ) $(VL_OBJ) $(VLS_OBJ) $(filter-out Shell/InterpolantMinimizer.o Shell/AnswerExtractor.o Shell/BFNTMainLoop.o, $(VS_OBJ)) $(PARSE_OBJ) $(LIB_DEP) $(OTHER_CL_DEP)
VCLAUSIFY_BASIC := $(VD_OBJ) $(VL_OBJ) $(VLS_OBJ) $(filter-out Shell/InterpolantMinimizer.o Shell/AnswerExtractor.o, $(VS_OBJ)) $(PARSE_OBJ) $(LIB_DEP) $(OTHER_CL_DEP)
VSAT_BASIC := $(VD_OBJ) $(VL_OBJ) $(VLS_OBJ) $(VSAT_OBJ) Test/CheckedSatSolver.o $(LIB_DEP)
#VGROUND_BASIC := $(VD_OBJ) $(VL_OBJ) $(VK_OBJ) $(VI_OBJ) $(VSAT_OBJ) $(VS_OBJ) $(VT_OBJ)

Expand Down
Loading