Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy shaders #1004

Merged
merged 2 commits into from
Jun 3, 2021
Merged

remove legacy shaders #1004

merged 2 commits into from
Jun 3, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jun 3, 2021

#496

remove shaders

  • VRM/UnlitTexture(Unlit/Textureでよい)
  • VRM/UnlitTransparent(Unlit/Transparentでよい)
  • VRM/UnlitCutout(Unlit/Cutoutでよい)
  • VRM/UnlitTransparentZWrite(GLTF非互換で仕様化もされていない) => 半透明かつZWriteはMToonで可能なのでそちらを使ってください。

@ousttrue ousttrue added this to the v0.76 milestone Jun 3, 2021
@ousttrue ousttrue requested a review from Santarh June 3, 2021 05:57
Santarh
Santarh previously approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@ousttrue
空になった VrmUnlitShaders フォルダを削除。 Resources　を減らし
c7dfb00 
* UniUnlit/Resources/UniUnlit.shader を UniUnlit/Runtime/UniUnlit.shader に移動
* UniGLTF/Resources/Shaders/xxx.shader を UniGLTF/IO/TextureIO/Shaders/xxx.shader に移動
@ousttrue ousttrue requested a review from Santarh June 3, 2021 06:09
Santarh
Santarh approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

要チェック

  • 使用ユーザに、ShaderVariantCollection の使用を推奨する
  • Resources.Load でシェーダはロードできなくなる

@ousttrue ousttrue merged commit d373d1f into vrm-c:master Jun 3, 2021
@ousttrue ousttrue mentioned this pull request Jun 7, 2021
Merged
ousttrue added a commit to ousttrue/UniVRM that referenced this pull request Jun 7, 2021
@ousttrue
古いシェーダー名をフォールバック vrm-c#1004
2e659da
@ousttrue ousttrue mentioned this pull request Jun 7, 2021
Merged
@ousttrue ousttrue deleted the feature/remove_legacy_shaders branch October 27, 2021 06:00
@Santarh Santarh mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Santarh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.76
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Santarh