Skip to content

Commit

Permalink
Don't stop importing TMXs on first error
Browse files Browse the repository at this point in the history
This is (temporarily) uglier, but more functional, UI. Don't terminate
imports of multiple TMX files if an error occurs, continue with the rest
of the files.

See #748.
  • Loading branch information
vslavik committed May 13, 2022
1 parent 4c4fef3 commit 5984951
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/prefsdlg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -619,8 +619,12 @@ class TMPageWindow : public PrefsPanel
wxOK | wxICON_ERROR
));
err->SetExtendedMessage(DescribeCurrentException());
err->ShowWindowModalThenDo([err](int){});
break;
// FIXME: can't use ShowWindowModalThenDo, as would be better, because multiple
// errors may occur in this loop. See https://github.com/vslavik/poedit/issues/748
if (paths.size() == 1)
err->ShowWindowModalThenDo([err](int){});
else
err->ShowModal();
}
}
UpdateStats();
Expand Down

0 comments on commit 5984951

Please sign in to comment.