Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch import of TMX files cancelled on first error #748

Open
Eitot opened this issue Apr 25, 2022 · 1 comment
Open

Batch import of TMX files cancelled on first error #748

Eitot opened this issue Apr 25, 2022 · 1 comment

Comments

@Eitot
Copy link

Eitot commented Apr 25, 2022

When importing multiple TMX files in one batch, poedit cancels the import when it encounters one file that e.g. has no translations or is malformed.

I have encountered this while trying to import hundreds of TMX files (Apple glossary files converted into TMX files). There are dozens of “empty” and occasional malformed TMX files among them that cause the import to be interrupted.

The problem seems to be on the one hand that TMX::ImportFromFile throws errors and that TMPageWindow.OnImportTMX on the other hand handles those errors by breaking out of the loop, thereby cancelling the import altogether.

Some possible improvements would be:

  1. asking the user upon the first error whether to: (1) cancel, (2) continue or (3) continue and ignore all further errors;
  2. ignoring some errors for batch imports only, such as the error when a file has no translations; or
  3. showing just one dialog when the import is completed to inform the user about errors that occurred.

poedit 3.0.1 (6416)
macOS 12.3.1 (21E258)

vslavik added a commit that referenced this issue May 13, 2022
This is (temporarily) uglier, but more functional, UI. Don't terminate
imports of multiple TMX files if an error occurs, continue with the rest
of the files.

See #748.
@vslavik
Copy link
Owner

vslavik commented May 13, 2022

Leaving open for non-crappy UI implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants