Resource Identifier metadata #206
Conversation
| %{data: source_data, conn: conn}, | ||
| %{identifer_meta: identifier_metadata_func}) | ||
| when is_function(identifier_metadata_func) do | ||
| identifier_metadata_func.(source_data, destination_data, conn) |
There was a problem hiding this comment.
Nice, does this work? I have had some trouble getting functions working when passed to the DSL.
|
@alanpeabody The function thing didn't work, since the DSL macro needs to unquote it. I thought it did for some reason. Good catch :D |
|
@alanpeabody Hey guys! Any thoughts on this? |
|
Hey @zachdaniel honestly is looks great, however I am hesitant to merge it until the other meta data is supported and I can see the DSL/Implementation in full. I know it probably isn't something you need but adding it isn't my top priority ATM either, though I would like to get around to it sometime. |
|
Do you mean metadata for each included item? If so, I don't know if there is a good way to do it, because it would have to override the data that is generated by the destination serializer's metadata function. So having meta in the includes is already supported. |
|
Hi @alanpeabody Just curious if there's been any movement on this. |
|
Any news on this one? Would love to get it merged in as well... ! 😃 |
Attempting to address #202