-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Identifier metadata #206
Closed
zachdaniel
wants to merge
7
commits into
vt-elixir:master
from
zachdaniel:add-meta-with-configuration
Closed
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7b4bfdb
added meta configuration for relationships
zachdaniel 9237904
added some docs
zachdaniel 48d42a7
improved logic around setting meta
zachdaniel 1d78620
using a three argument function instead of a configuration
zachdaniel b3b9987
solved for nil case
zachdaniel 47ceedc
removed the ability to pass in a function
zachdaniel 8276357
fixed documentation
zachdaniel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
defimpl JaSerializer.Formatter, for: JaSerializer.Builder.ResourceIdentifier do | ||
def format(resource) do | ||
%{ | ||
required_attributes = %{ | ||
"id" => to_string(resource.id), | ||
"type" => resource.type | ||
} | ||
|
||
add_meta(required_attributes, resource) | ||
end | ||
|
||
defp add_meta(resource, %{meta: nil}), do: resource | ||
defp add_meta(resource, %{meta: meta}), do: Map.put(resource, "meta", meta) | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, does this work? I have had some trouble getting functions working when passed to the DSL.