Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use recommended way to disable webpack-hot-middleware log #778

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Use recommended way to disable webpack-hot-middleware log #778

merged 1 commit into from
Aug 1, 2017

Conversation

sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Jun 29, 2017 •
edited
Loading

For disabling logs for hotMiddleware, we need not pass a noop, we can use false.

Relevant docs - https://github.com/glenjamin/webpack-hot-middleware#middleware

@sudo-suhas sudo-suhas mentioned this pull request Jun 29, 2017
Merged
@LinusBorg LinusBorg self-requested a review July 12, 2017 21:40
@LinusBorg LinusBorg self-assigned this Jul 12, 2017
@LinusBorg
Copy link
Contributor

This was done this way because it's shown this way in the README of friendrly-errors-webpack-template

https://www.npmjs.com/package/friendly-errors-webpack-plugin#turn-off-errors

But if you don't have any issues with that "correct" setting, I can merge it.

@sudo-suhas
Copy link
Contributor Author

I wasn't aware of that.

I have made a PR to the repo with a similar change - geowarin/friendly-errors-webpack-plugin#57 updating the readme.
Although I doubt there will be any significance to the no-op, let us wait for their response.

Also, rebased.

@sudo-suhas
Copy link
Contributor Author

@LinusBorg No activity in the friendly-errors-webpack-plugin repo. This PR is a very minor change so could we please merge it in?

@LinusBorg LinusBorg merged commit e1f781e into vuejs-templates:master Aug 1, 2017
@sudo-suhas sudo-suhas deleted the fix_hot_mw_conf branch August 1, 2017 04:59
grantcarthew added a commit to vue-foundation/vue-foundation that referenced this pull request Aug 2, 2017
@grantcarthew
disable webpack-hot-middleware log
56644f8 
Use recommended way to disable webpack-hot-middleware log: vuejs-templates/webpack#778
JasonGrubb pushed a commit to JasonGrubb/webpack that referenced this pull request Aug 30, 2017
@rwb7041 @JasonGrubb
Beltrw mods (#9)
f1b859d 
* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753)

They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')`

* build: Configure targets.browser for babel-preset-env (vuejs-templates#763)

* Remove inconsistent spacing (vuejs-templates#754)

* feat(gitignore): include common editor directories (vuejs-templates#774)

* feat(gitignore): include common editor directories

add common editor files and directories to .gitignore

closes vuejs-templates#772

* feat(gitignore): remove .vscode directory

remove .vscode directory from .gitignore

* Video audio loader (vuejs-templates#765)

* gitignore vscode

* media loader

audio and video tag

* Remove vscode gitignore

* Add \n back

* fix missing closing bracket

* add default values (img, image)

* Upgrade vue-router to v2.6.0 (vuejs-templates#777)

* Fix console error (vuejs-templates#784)

Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`

* Fix proxy example (fix vuejs-templates#780)

the glob pattern was too narrow, woudl not catch subpaths.

* Fix autoprefixer explanation (vuejs-templates#798)

The parameter to set in package.json is named "browserslist".

* chore: Bump dev dependencies for template (vuejs-templates#790)

* fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778)

* Move Chat: Gitter -> Discord (vuejs-templates#869)

* Remove unnecessary space and comma (vuejs-templates#866)

* load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)

* Return exit code 1 when npm run build fails (vuejs-templates#854)

* fix standard eslint config link (vuejs-templates#834)

* fix ci build faild (vuejs-templates#857)

* Removing Vue.config.debug usage from documentation (vuejs-templates#871)

* Removing Vue.config.debug usage from documentation

It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed

* Update env.md

* fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)

* bump vue & vue-router dependencies

* Specify the address to listen on (vuejs-templates#759)

Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.

* add HashedModuleIdsPlugin when build (vuejs-templates#870)

* Add support for linked modules (vuejs-templates#688)

* chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)

* fix vuejs-templates#877

* Revert vuejs-templates#688, fix vuejs-templates#879

We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879

* revert: vuejs-templates#759

That's actually not a good idea when you e.g. want to access the dev server from your mobile.

* - Re-added check for router
- Modified eslint file to use standard and have M be a global
rwb7041 added a commit to JasonGrubb/webpack that referenced this pull request Aug 31, 2017
@rwb7041 @JasonGrubb
Merged in beltrw_mods (pull request #1)
0ed883f 
Beltrw mods

* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753)

    They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')`

* build: Configure targets.browser for babel-preset-env (vuejs-templates#763)

* Remove inconsistent spacing (vuejs-templates#754)

* feat(gitignore): include common editor directories (vuejs-templates#774)

    * feat(gitignore): include common editor directories

    add common editor files and directories to .gitignore

    closes vuejs-templates#772

    * feat(gitignore): remove .vscode directory

    remove .vscode directory from .gitignore

* Video audio loader (vuejs-templates#765)

    * gitignore vscode

    * media loader

    audio and video tag

    * Remove vscode gitignore

    * Add \n back

    * fix missing closing bracket

    * add default values (img, image)

* Upgrade vue-router to v2.6.0 (vuejs-templates#777)

* Fix console error (vuejs-templates#784)

    Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`

* Fix proxy example (fix vuejs-templates#780)

    the glob pattern was too narrow, woudl not catch subpaths.

* Fix autoprefixer explanation (vuejs-templates#798)

    The parameter to set in package.json is named "browserslist".

* chore: Bump dev dependencies for template (vuejs-templates#790)

* fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778)

* Move Chat: Gitter -> Discord (vuejs-templates#869)

* Remove unnecessary space and comma (vuejs-templates#866)

* load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)

* Return exit code 1 when npm run build fails (vuejs-templates#854)

* fix standard eslint config link (vuejs-templates#834)

* fix ci build faild (vuejs-templates#857)

* Removing Vue.config.debug usage from documentation (vuejs-templates#871)

    * Removing Vue.config.debug usage from documentation

    It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed

    * Update env.md

* fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)

* bump vue & vue-router dependencies

* Specify the address to listen on (vuejs-templates#759)

    Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.

* add HashedModuleIdsPlugin when build (vuejs-templates#870)

* Add support for linked modules (vuejs-templates#688)

* chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)

* fix vuejs-templates#877

* Revert vuejs-templates#688, fix vuejs-templates#879

    We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879

* revert: vuejs-templates#759

    That's actually not a good idea when you e.g. want to access the dev server from your mobile.

* - Re-added check for router
    - Modified eslint file to use standard and have M be a global

Approved-by: Jason Grubb <grubbjt@appstate.edu>
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Oct 13, 2017
@sudo-suhas @frandiox
fix: Use false to disable webpack-hot-middleware log (vuejs-templates…
fc0ad51 
…#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg Awaiting requested review from LinusBorg

Assignees

@LinusBorg LinusBorg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudo-suhas @LinusBorg