Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify elementCount custom assertions #898

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Simplify elementCount custom assertions #898

merged 2 commits into from
Nov 21, 2017

Commits on Sep 3, 2017

  1. Improve custom Nightwatch assertion comment readability 

    Standardize capitalization, punctuation
Use common language
Reduce word count
    @robwierzbowski
    robwierzbowski committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    84a844a View commit details
    Browse the repository at this point in the history

  2. Clarify elementCount arguments 

    Before this commit the term `selector` was used for two separate arguments in
two separate scopes. Rename the function passed to the browser so the developer
understands that these are two arguments/two scopes/not the same value.
    @robwierzbowski
    robwierzbowski committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    c3a2181 View commit details
    Browse the repository at this point in the history