Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify elementCount custom assertions #898

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Simplify elementCount custom assertions #898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a844a
Improve custom Nightwatch assertion comment readability
robwierzbowski Sep 3, 2017
c3a2181
Clarify elementCount arguments
robwierzbowski Sep 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions template/test/e2e/custom-assertions/elementCount.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
// A custom Nightwatch assertion.
// the name of the method is the filename.
// can be used in tests like this:
// The assertion name is the filename.
// Example usage:
//
// browser.assert.elementCount(selector, count)
//
// for how to write custom assertions see
// For more information on custom assertions see:
// http://nightwatchjs.org/guide#writing-custom-assertions

exports.assertion = function (selector, count) {
this.message = 'Testing if element <' + selector + '> has count: ' + count{{#if_eq lintConfig "airbnb"}};{{/if_eq}}
this.expected = count{{#if_eq lintConfig "airbnb"}};{{/if_eq}}
Expand All @@ -17,8 +18,8 @@ exports.assertion = function (selector, count) {
}
this.command = function (cb) {
var self = this{{#if_eq lintConfig "airbnb"}};{{/if_eq}}
return this.api.execute(function (selector) {
return document.querySelectorAll(selector).length{{#if_eq lintConfig "airbnb"}};{{/if_eq}}
return this.api.execute(function (selectorToCount) {
return document.querySelectorAll(selectorToCount).length{{#if_eq lintConfig "airbnb"}};{{/if_eq}}
}, [selector], function (res) {
cb.call(self, res){{#if_eq lintConfig "airbnb"}};{{/if_eq}}
}){{#if_eq lintConfig "airbnb"}};{{/if_eq}}
Expand Down