Fix checking for script setup in vue/require-typed-ref (#2427)

vuejs · May 9, 2024 · a3c98d8 · a3c98d8
1 parent 98e030a
commit a3c98d8
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 7 deletions.
diff --git a/lib/rules/require-typed-ref.js b/lib/rules/require-typed-ref.js
@@ -44,13 +44,23 @@ module.exports = {
       return {}
     }
 
-    const scriptSetup = utils.getScriptSetupElement(context)
-    if (
-      scriptSetup &&
-      !utils.hasAttribute(scriptSetup, 'lang', 'ts') &&
-      !utils.hasAttribute(scriptSetup, 'lang', 'typescript')
-    ) {
-      return {}
+    if (utils.isVueFile(filename)) {
+      const sourceCode = context.getSourceCode()
+      const documentFragment =
+        sourceCode.parserServices.getDocumentFragment &&
+        sourceCode.parserServices.getDocumentFragment()
+      if (!documentFragment) {
+        return {}
+      }
+      const scripts = documentFragment.children.filter(
+        /** @returns {element is VElement} */
+        (element) => utils.isVElement(element) && element.name === 'script'
+      )
+      if (
+        scripts.every((script) => !utils.hasAttribute(script, 'lang', 'ts'))
+      ) {
+        return {}
+      }
     }
 
     const defines = iterateDefineRefs(

diff --git a/tests/lib/rules/require-typed-ref.js b/tests/lib/rules/require-typed-ref.js
@@ -86,6 +86,20 @@ tester.run('require-typed-ref', rule, {
       `,
       languageOptions: { parser: require('vue-eslint-parser') }
     },
+    {
+      filename: 'test.vue',
+      code: `
+        <script>
+          import { ref } from 'vue'
+          export default {
+            setup() {
+              const count = ref()
+            }
+          }
+        </script>
+      `,
+      languageOptions: { parser: require('vue-eslint-parser') }
+    },
     {
       filename: 'test.js',
       code: `
@@ -217,6 +231,30 @@ tester.run('require-typed-ref', rule, {
       ],
       languageOptions: { parser: require('vue-eslint-parser') }
     },
+    {
+      filename: 'test.vue',
+      code: `
+        <script lang="ts">
+          import { ref } from 'vue'
+          export default {
+            setup() {
+              const count = ref()
+            }
+          }
+        </script>
+      }
+      `,
+      errors: [
+        {
+          messageId: 'noType',
+          line: 6,
+          column: 29,
+          endLine: 6,
+          endColumn: 34
+        }
+      ],
+      languageOptions: { parser: require('vue-eslint-parser') }
+    },
     {
       filename: 'test.ts',
       code: `