Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking for script setup in vue/require-typed-ref #2427

Merged
merged 3 commits into from
May 9, 2024

Conversation

kovalchukq
Copy link
Contributor

No description provided.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please fix the lint error (run npm run lint:fix)? Otherwise, this looks good to me.

@ota-meshi
Copy link
Member

Hmm... What is this PR fixing? Could you please explain the details?

@kovalchukq
Copy link
Contributor Author

kovalchukq commented Mar 15, 2024

Hmm... What is this PR fixing? Could you please explain the details?
This PR skip checking vue/require-typed-ref rule for vue files that doesn't have lang="ts".

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response.
Thank you for your explanation.
LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants