Link to custom-elements-everywhere.com #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue.
|
I'm not sure about this TBH. Time to ping @yyx990803 I guess 😅 |
yyx990803
requested changes
Mar 1, 2019
src/v2/guide/index.md
Outdated
| @@ -393,6 +393,8 @@ You may have noticed that Vue components are very similar to **Custom Elements** | |||
|
|
|||
| 2. Vue components provide important features that are not available in plain custom elements, most notably cross-component data flow, custom event communication and build tool integrations. | |||
|
|
|||
| According to <https://custom-elements-everywhere.com/#vue>, Vue has a great interoperability with **Custom Elements**. | |||
There was a problem hiding this comment.
We can provide a bit more context:
"Although Vue doesn't use custom elements internally, it has great interoperability when it comes to consuming or distributing as custom elements. [According to ...]. Vue CLI also supports building Vue components that register themselves as native custom elements."
Suggestions added, to give more context regarding Custom Elements.
phanan
requested changes
Mar 1, 2019
src/v2/guide/index.md
Outdated
| @@ -393,6 +393,11 @@ You may have noticed that Vue components are very similar to **Custom Elements** | |||
|
|
|||
| 2. Vue components provide important features that are not available in plain custom elements, most notably cross-component data flow, custom event communication and build tool integrations. | |||
|
|
|||
| Although Vue doesn't use custom elements internally, it has great interoperability when it comes to | |||
src/v2/guide/index.md
Outdated
| @@ -393,6 +393,11 @@ You may have noticed that Vue components are very similar to **Custom Elements** | |||
|
|
|||
| 2. Vue components provide important features that are not available in plain custom elements, most notably cross-component data flow, custom event communication and build tool integrations. | |||
|
|
|||
| Although Vue doesn't use custom elements internally, it has great interoperability when it comes to | |||
| consuming or distributing as custom elements. According to <https://custom-elements-everywhere.com/#vue>, | |||
There was a problem hiding this comment.
In order to keep the words concise while still maintaining the same information, I'd suggest something like:
Although Vue doesn't use custom elements internally, it has great interoperability when it comes to consuming or distributing as custom elements. Vue CLI also supports building Vue components that register themselves as native custom elements.
Changes putted all in one line. Link placed embedded in the text, to maintain consistency.
|
LGTM, thanks! |
mazipan
pushed a commit
to vuejs-id/docs
that referenced
this pull request
Mar 7, 2019
* Link to custom-elements-everywhere.com (vuejs#2039) The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue. * Updated Nuxtent link (vuejs#2041) * Fix wrong statement about arrow function and bound this (vuejs#2040) * Fix wrong statement about arrow function and bound this Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466 * Update src/v2/guide/instance.md Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com> * Update instance.md Remove unnecessary `a` * translate filters * fix translate filters * update translate filters
mazipan
pushed a commit
to vuejs-id/docs
that referenced
this pull request
Mar 8, 2019
* Link to custom-elements-everywhere.com (vuejs#2039) The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue. * Updated Nuxtent link (vuejs#2041) * Fix wrong statement about arrow function and bound this (vuejs#2040) * Fix wrong statement about arrow function and bound this Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466 * Update src/v2/guide/instance.md Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com> * Update instance.md Remove unnecessary `a` * fix: routing translation * fix: fixed, as suggested by @nusendra and @mazipan
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 14, 2019
The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue.
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 20, 2019
The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site https://custom-elements-everywhere.com runs a suite of tests against a framework to
identify interoperability issues, and highlight potential fixes already implemented in other frameworks.
This is a great way to give more confidence while choosing Vue.