-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong statement about arrow function and bound this #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466
phanan
reviewed
Mar 3, 2019
Good point! I've suggested some changes to make the explanation more concise, can you take a look? |
Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com>
Remove unnecessary `a`
LGTM |
Thanks a lot! |
mazipan
pushed a commit
to vuejs-id/docs
that referenced
this pull request
Mar 7, 2019
* Link to custom-elements-everywhere.com (vuejs#2039) The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue. * Updated Nuxtent link (vuejs#2041) * Fix wrong statement about arrow function and bound this (vuejs#2040) * Fix wrong statement about arrow function and bound this Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466 * Update src/v2/guide/instance.md Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com> * Update instance.md Remove unnecessary `a` * translate filters * fix translate filters * update translate filters
mazipan
pushed a commit
to vuejs-id/docs
that referenced
this pull request
Mar 8, 2019
* Link to custom-elements-everywhere.com (vuejs#2039) The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to identify interoperability issues, and highlight potential fixes already implemented in other frameworks. This is a great way to give more confidence while choosing Vue. * Updated Nuxtent link (vuejs#2041) * Fix wrong statement about arrow function and bound this (vuejs#2040) * Fix wrong statement about arrow function and bound this Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466 * Update src/v2/guide/instance.md Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com> * Update instance.md Remove unnecessary `a` * fix: routing translation * fix: fixed, as suggested by @nusendra and @mazipan
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 14, 2019
* Fix wrong statement about arrow function and bound this Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466 * Update src/v2/guide/instance.md Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com> * Update instance.md Remove unnecessary `a`
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 20, 2019
* Fix wrong statement about arrow function and bound this Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466 * Update src/v2/guide/instance.md Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com> * Update instance.md Remove unnecessary `a`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stating that arrow functions are bound to it's parent
this
is wrong, arrow functions does not have athis
at all. More: https://twitter.com/getify/status/1101521219243966466