Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong statement about arrow function and bound this #2040

Merged
merged 3 commits into from
Mar 3, 2019

Conversation

KadoBOT
Copy link
Contributor

@KadoBOT KadoBOT commented Mar 2, 2019

Stating that arrow functions are bound to it's parent this is wrong, arrow functions does not have a this at all. More: https://twitter.com/getify/status/1101521219243966466

Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466
src/v2/guide/instance.md Outdated Show resolved Hide resolved
@phanan
Copy link
Member

phanan commented Mar 3, 2019

Good point! I've suggested some changes to make the explanation more concise, can you take a look?

phanan and others added 2 commits March 3, 2019 18:09
Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com>
Remove unnecessary `a`
@KadoBOT
Copy link
Contributor Author

KadoBOT commented Mar 3, 2019

Good point! I've suggested some changes to make the explanation more concise, can you take a look?

LGTM

@phanan phanan merged commit 93eefd3 into vuejs:master Mar 3, 2019
@phanan
Copy link
Member

phanan commented Mar 3, 2019

Thanks a lot!

mazipan pushed a commit to vuejs-id/docs that referenced this pull request Mar 7, 2019
* Link to custom-elements-everywhere.com (vuejs#2039)

The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to
identify interoperability issues, and highlight potential fixes already implemented in other frameworks.

This is a great way to give more confidence while choosing Vue.

* Updated Nuxtent link (vuejs#2041)

* Fix wrong statement about arrow function and bound this (vuejs#2040)

* Fix wrong statement about arrow function and bound this

Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466

* Update src/v2/guide/instance.md

Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com>

* Update instance.md

Remove unnecessary `a`

* translate filters

* fix translate filters

* update translate filters
mazipan pushed a commit to vuejs-id/docs that referenced this pull request Mar 8, 2019
* Link to custom-elements-everywhere.com (vuejs#2039)

The site <https://custom-elements-everywhere.com> runs a suite of tests against a framework to
identify interoperability issues, and highlight potential fixes already implemented in other frameworks.

This is a great way to give more confidence while choosing Vue.

* Updated Nuxtent link (vuejs#2041)

* Fix wrong statement about arrow function and bound this (vuejs#2040)

* Fix wrong statement about arrow function and bound this

Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466

* Update src/v2/guide/instance.md

Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com>

* Update instance.md

Remove unnecessary `a`

* fix: routing translation

* fix: fixed, as suggested by @nusendra and @mazipan
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 14, 2019
* Fix wrong statement about arrow function and bound this

Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466

* Update src/v2/guide/instance.md

Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com>

* Update instance.md

Remove unnecessary `a`
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 20, 2019
* Fix wrong statement about arrow function and bound this

Stating that arrow functions are bound to it's parent `this` is wrong, arrow functions does not have a `this` at all. More: https://twitter.com/getify/status/1101521219243966466

* Update src/v2/guide/instance.md

Co-Authored-By: KadoBOT <ricardo.ambrogi@gmail.com>

* Update instance.md

Remove unnecessary `a`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants