Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PropSync and Model decorators for vue property decorator #2164

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Fix PropSync and Model decorators for vue property decorator #2164

merged 4 commits into from
Aug 25, 2020

Conversation

yoyo930021
Copy link
Member

@octref octref force-pushed the fix-PropSync-Model branch from 4278488 to 49ae1d1 Compare August 25, 2020 06:37
octref
octref approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍 Just a small nitpick. No need to create only-use-once variables.

server/src/modes/script/componentInfo.ts Outdated Show resolved Hide resolved
@octref
Copy link
Member

octref commented Aug 25, 2020

I'll just commit the small change and merge.

@octref octref merged commit c79373c into vuejs:master Aug 25, 2020
@octref octref mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyo930021 @octref