Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change props validation, Fix #2141 #2166

Closed
wants to merge 2 commits into from
Closed

Change props validation, Fix #2141 #2166

wants to merge 2 commits into from

Conversation

yoyo930021
Copy link
Member

Fixed #2141

@yoyo930021 yoyo930021 changed the title Change props validation Change props validation, Fix #2141 Aug 14, 2020
@yoyo930021 yoyo930021 mentioned this pull request Aug 25, 2020
Merged
@octref
Copy link
Member

octref commented Aug 25, 2020

For some reason rebase/merge all creates a lot of conflicts. Wanna open a new clean PR? I guess you were waiting for #2164 which I just merged.

@yoyo930021
Copy link
Member Author

For some reason rebase/merge all creates a lot of conflicts. Wanna open a new clean PR? I guess you were waiting for #2164 which I just merged.

This PR is waiting for #2164 and #2170
It is not complete, and it is Draft.

@octref
Copy link
Member

octref commented Aug 25, 2020

@yoyo930021 Just merged both. Go ahead.

@octref octref force-pushed the change-props-validation branch from 19f067a to 483952a Compare August 26, 2020 06:05
@yoyo930021
Copy link
Member Author

Replace by #2216

@yoyo930021 yoyo930021 closed this Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prop with required: false or default value should not trigger prop validation error when not provided
2 participants
@yoyo930021 @octref