Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2141 #2216

Merged
merged 5 commits into from
Sep 3, 2020
Merged

Fix #2141 #2216

merged 5 commits into from
Sep 3, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Aug 31, 2020 •
edited
Loading

Fixed #2141

@yoyo930021 yoyo930021 mentioned this pull request Aug 31, 2020
Closed
@yoyo930021 yoyo930021 requested a review from octref August 31, 2020 14:18
octref
octref approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏
The only thing I can find for improvement is to give detailed a more explicit name. Currently it's a bit ambiguous (what does a detailed prop mean?).

@octref octref merged commit 313812d into vuejs:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triforcely triforcely triforcely approved these changes

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prop with required: false or default value should not trigger prop validation error when not provided
3 participants
@yoyo930021 @octref @triforcely