Fix prop validation diagnostics not working for PascalCase components in templates #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triforcely
changed the title
yoyo930021
reviewed
Aug 15, 2020
| if (d) { | ||
| diagnostics.push(d); | ||
| if (n.tag) { | ||
| const kebabCaseTag = kebabCase(n.tag); |
There was a problem hiding this comment.
Maybe we can use getSameTagInSet function?
const componetProps = getSameTagInSet(childComponentToProps, n.tag)
if (componetProps) {
const d = generateDiagnostic(n, componetProps, document);
if (d) {
diagnostics.push(d);
}
}There was a problem hiding this comment.
Hey. I'm new to the code base, so I didn't know this utility function exists. Thank you, I updated the code!
triforcely
force-pushed
the
2168-prop-diagnostics-broken-for-pascal-case
branch
from
7b70d8e to
0b9e393
Compare
yoyo930021
approved these changes
Aug 15, 2020
|
Does anything else need to be added to this PR for it to get merged? |
You only need to wait for review by @octref. |
…ase in templates (as opposed to kebab-case) vuejs#2168
octref
force-pushed
the
2168-prop-diagnostics-broken-for-pascal-case
branch
from
0b9e393 to
b7744c6
Compare
octref
approved these changes
Aug 25, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problem with 'PascalCase' component names in vue templates.