Pass version in new template sourceFile for ts perf #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
force-pushed
the
research-ts-pref
branch
2 times, most recently
from
da57ffb
to
de10c9f
Compare
yoyo930021
changed the title
3 tasks
yoyo930021
force-pushed
the
research-ts-pref
branch
2 times, most recently
from
3aecedd
to
a61afd5
Compare
|
It seems to be the ultimate solution. Maybe this PR can also fix #2150 |
Merged
yoyo930021
force-pushed
the
research-ts-pref
branch
from
a61afd5
to
90cac01
Compare
|
1 week after applying manually this patch. No bug for me, and it solved the slowness. |
octref
force-pushed
the
research-ts-pref
branch
from
90cac01
to
53ef21d
Compare
3 tasks
|
@octref Great work are you going to push a release with this fix soon? |
It is in v0.29.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2192
Fixed #2163
Fixed #1731
Reason: #2192 (comment)