Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: align build system with vue 3 #1715

Merged
merged 10 commits into from
Apr 20, 2020
Merged

build: align build system with vue 3 #1715

merged 10 commits into from
Apr 20, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 16, 2020

This PR updates the build system for Vuex 4 to align with Vue 3.

  • Bundles are now aligned with Vue 3 such as vuex.esm-bundler.js and vuex.global.js.
  • Using __DEV__ global variable and rollup replace plugin to handle process.env.NODE_ENV !== 'production' replacement.
  • Remove dist folder from commit expect for logger.d.ts, plus organize .gitignore file to match the latest repository structure.
  • Make index.js to be the primary esm entry point by renaming index.esm.js to index.js, and renaming index.js to index.cjs.
  • Use index file without the build in test cases.
  • ⚠️ The "release script" should be updated once build: add conventional changelog support #1707 is merged in dev branch. Included the "release script" as well.

@kiaking kiaking added enhancement New feature or request 4.x labels Apr 16, 2020
@kiaking kiaking requested a review from ktsn April 16, 2020 08:25
@kiaking kiaking self-assigned this Apr 16, 2020
types/typings
types/test/*.js
explorations
/dist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add !/dist/logger.d.ts ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point! Yeah I'll add that. logger.d.ts will be tracked regardless of it because it is already committed, but it's nice to have precise definition 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And fixed 👍

@kiaking
Copy link
Member Author

kiaking commented Apr 19, 2020

@ktsn Please hold on merging this one. I'll include the changes from #1707 to this PR as well.

@kiaking
Copy link
Member Author

kiaking commented Apr 19, 2020

@ktsn OK, I think it's done. I've added next tag to the release script since 4.0 should be always release as next.

@kiaking
Copy link
Member Author

kiaking commented Apr 19, 2020

Hah, not sure why e2e test is failing... maybe running again would solve it...?

@kiaking
Copy link
Member Author

kiaking commented Apr 20, 2020

Added jsdelivr support, and renamed esm module to esm-bundler to align with the latest Vue 3 commit.

@kiaking
Copy link
Member Author

kiaking commented Apr 20, 2020

Hmmm... I still don't know why E2E test is failing on CI. It works locally... 🤔

@kiaking
Copy link
Member Author

kiaking commented Apr 20, 2020

YES!!! The test has passed. @ktsn If you were to merge this, please don't forget to squash the commits 😅

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@ktsn ktsn merged commit df3f690 into 4.0 Apr 20, 2020
@ktsn ktsn deleted the 4.0-new-build-system branch April 20, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants