-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: align build system with vue 3 #1715
Conversation
types/typings | ||
types/test/*.js | ||
explorations | ||
/dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to add !/dist/logger.d.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point! Yeah I'll add that. logger.d.ts
will be tracked regardless of it because it is already committed, but it's nice to have precise definition 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And fixed 👍
1d64911
to
503cfd4
Compare
503cfd4
to
b3cf6a6
Compare
@ktsn OK, I think it's done. I've added |
Hah, not sure why e2e test is failing... maybe running again would solve it...? |
Added |
Hmmm... I still don't know why E2E test is failing on CI. It works locally... 🤔 |
YES!!! The test has passed. @ktsn If you were to merge this, please don't forget to squash the commits 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
This PR updates the build system for Vuex 4 to align with Vue 3.
vuex.esm-bundler.js
andvuex.global.js
.__DEV__
global variable and rollup replace plugin to handleprocess.env.NODE_ENV !== 'production'
replacement.dist
folder from commit expect forlogger.d.ts
, plus organize.gitignore
file to match the latest repository structure.index.js
to be the primary esm entry point by renamingindex.esm.js
toindex.js
, and renamingindex.js
toindex.cjs
.⚠️ The "release script" should be updated once build: add conventional changelog support #1707 is merged in Included the "release script" as well.dev
branch.