-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: align build system with vue 3 #1715
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cdf13c0
build: align build system with vue 3
kiaking 50f9308
chore: do not ignore logger.d.ts
kiaking ef88ae0
chore: update yarn.lock file to include all packages
kiaking b3cf6a6
chore: publish release as "next" in release script
kiaking bfcb86d
build: add jsdelivr support and rename `esm` to `esm-browser`
kiaking 31bace9
build: update lock file to fix ci e2e test failing
kiaking 95a3e2e
build: update chromedriver to see if it fixes the ci failure
kiaking 14414ec
build: refresh lock file to finally fix the failing ci e2e test
kiaking 7b525d7
test: try referencing class instead of elements to see if this fix th…
kiaking bcae2ab
test: use tab to emit blur event to fix ci test failure
kiaking File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,8 @@ | |
"root": true, | ||
"extends": [ | ||
"plugin:vue-libs/recommended" | ||
] | ||
], | ||
"globals": { | ||
"__DEV__": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,11 @@ | ||
.DS_Store | ||
node_modules | ||
TODO.md | ||
lib | ||
docs/.vuepress/dist | ||
examples/**/build.js | ||
types/typings | ||
types/test/*.js | ||
explorations | ||
/dist | ||
!/dist/logger.d.ts | ||
/docs/.vuepress/dist | ||
/examples/**/build.js | ||
/node_modules | ||
/test/e2e/reports | ||
/test/e2e/screenshots | ||
/types/typings | ||
/types/test/*.js | ||
*.log | ||
test/e2e/reports | ||
test/e2e/screenshots | ||
.DS_Store |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to add
!/dist/logger.d.ts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point! Yeah I'll add that.
logger.d.ts
will be tracked regardless of it because it is already committed, but it's nice to have precise definition 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And fixed 👍