-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(layout): use suspense to delay render of layout items #15229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnleider
force-pushed
the
next
branch
2 times, most recently
from
June 24, 2022 16:47
c62375c
to
c692f92
Compare
nekosaur
force-pushed
the
fix/15202-layout-ssr
branch
from
June 29, 2022 18:03
7d12980
to
e501d14
Compare
johnleider
previously approved these changes
Jul 5, 2022
johnleider
added
T: bug
Functionality that does not work as intended/expected
E: layout
Layout composable
labels
Jul 5, 2022
There's still vuejs/core#6095, I haven't seen it in this PR but I also have no idea why it happens in the first place. |
johnleider
reviewed
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for naming it layoutReady instead of isReady?
Everything else looks good.
Any news on when we'll see this one merged? 🙏 |
When vuejs/core#6095 is. |
MajesticPotatoe
force-pushed
the
next
branch
from
November 15, 2022 00:44
50e76f2
to
1057e25
Compare
johnleider
force-pushed
the
next
branch
3 times, most recently
from
November 29, 2022 23:53
b6aed82
to
ceaffe5
Compare
johnleider
added
the
upstream
Problem with a third party library that we may have to work around
label
Mar 3, 2023
KaelWD
force-pushed
the
master
branch
2 times, most recently
from
April 13, 2023 09:45
18ab9a4
to
aa22a14
Compare
johnleider
approved these changes
Feb 8, 2024
johnleider
added a commit
that referenced
this pull request
Feb 14, 2024
Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
yuwu9145
pushed a commit
that referenced
this pull request
Mar 16, 2024
Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0
pushed a commit
to VIXI0/vuetify
that referenced
this pull request
Mar 20, 2024
…15229) Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0
pushed a commit
to VIXI0/vuetify
that referenced
this pull request
Apr 1, 2024
…15229) Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0
pushed a commit
to VIXI0/vuetify
that referenced
this pull request
Apr 1, 2024
…15229) Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0
pushed a commit
to VIXI0/vuetify
that referenced
this pull request
Apr 1, 2024
…15229) Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0
pushed a commit
to VIXI0/vuetify
that referenced
this pull request
Apr 1, 2024
…15229) Co-authored-by: John Leider <john.j.leider@gmail.com> Co-authored-by: John Leider <john@vuetifyjs.com> Co-authored-by: Kael <kaelwd@gmail.com>
KaelWD
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #15202
same principle as in #15215
Motivation and Context
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).