Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): use suspense to delay render of layout items #15229

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Jun 8, 2022

Description

closes #15202

same principle as in #15215

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-navigation-drawer permanent>
      nav drawer

    </v-navigation-drawer>
    <v-app-bar>
      <v-toolbar-title>Title</v-toolbar-title>
    </v-app-bar>

    <v-main app>
      <v-container>
        Something!
      </v-container>
    </v-main>
  </v-app>

</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur self-assigned this Jun 11, 2022
@nekosaur nekosaur requested a review from KaelWD June 11, 2022 13:28
johnleider
johnleider previously approved these changes Jul 5, 2022
@johnleider johnleider added T: bug Functionality that does not work as intended/expected E: layout Layout composable labels Jul 5, 2022
@KaelWD KaelWD added the S: on hold The issue is on hold until further notice label Jul 5, 2022
@KaelWD
Copy link
Member

KaelWD commented Jul 5, 2022

There's still vuejs/core#6095, I haven't seen it in this PR but I also have no idea why it happens in the first place.

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for naming it layoutReady instead of isReady?

Everything else looks good.

@warflash
Copy link

Any news on when we'll see this one merged? 🙏

@KaelWD
Copy link
Member

KaelWD commented Aug 25, 2022

When vuejs/core#6095 is.

@KaelWD KaelWD marked this pull request as draft January 31, 2023 12:49
@KaelWD KaelWD changed the base branch from next to master February 5, 2023 14:27
@KaelWD KaelWD dismissed johnleider’s stale review February 5, 2023 14:27

The base branch was changed.

@johnleider johnleider added the upstream Problem with a third party library that we may have to work around label Mar 3, 2023
@KaelWD KaelWD force-pushed the master branch 2 times, most recently from 18ab9a4 to aa22a14 Compare April 13, 2023 09:45
@KaelWD KaelWD added this to the v3.6.0 (Nebula) milestone Feb 8, 2024
@KaelWD KaelWD self-assigned this Feb 8, 2024
@KaelWD KaelWD marked this pull request as ready for review February 8, 2024 03:47
@KaelWD KaelWD changed the base branch from master to dev February 8, 2024 03:49
@KaelWD KaelWD merged commit 727bc1a into dev Feb 14, 2024
17 of 18 checks passed
@KaelWD KaelWD deleted the fix/15202-layout-ssr branch February 14, 2024 08:16
johnleider added a commit that referenced this pull request Feb 14, 2024
Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
yuwu9145 pushed a commit that referenced this pull request Mar 16, 2024
Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Mar 20, 2024
…15229)

Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Apr 1, 2024
…15229)

Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Apr 1, 2024
…15229)

Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Apr 1, 2024
…15229)

Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Apr 1, 2024
…15229)

Co-authored-by: John Leider <john.j.leider@gmail.com>
Co-authored-by: John Leider <john@vuetifyjs.com>
Co-authored-by: Kael <kaelwd@gmail.com>
KaelWD added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: layout Layout composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.0.0] V-App-Bar Collapse On Reload Page
4 participants