Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.1.2] No types for VGrid components' props #16604

Closed
Tracked by #1812
ferferga opened this issue Feb 7, 2023 · 0 comments · Fixed by #16708
Closed
Tracked by #1812

[Bug Report][3.1.2] No types for VGrid components' props #16604

ferferga opened this issue Feb 7, 2023 · 0 comments · Fixed by #16708
Assignees
@yuwu9145
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected
Milestone
v3.1.x

Comments

@ferferga
Copy link
Contributor

ferferga commented Feb 7, 2023 •
edited
Loading

Environment

Vuetify Version: 3.1.2
Last working version: 2.6.14
Vue Version: 3.2.39
Browsers: Edge 109.0.1518.78
OS: Windows 11

Steps to reproduce

  • Clone the repo and checkout to the specified branch
  • Run npm run typecheck
  • See the huge amount of type errors caused by VRow and VCol components

Expected Behavior

All VGrid components (VRow and VCol) should have proper types declared. They're also missing in the documentation, probably because of the lack of declared typings as well (which prevents the generator from picking up those props)

Actual Behavior

  • No breakpoint props types are provided and they don't exist in the docs, besides them working perfectly

Reproduction Link

https://github.com/jellyfin/jellyfin-vue/tree/vite
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VGrid Covers issues involving VContainer, VLayout, VFlex labels Feb 7, 2023
@KaelWD KaelWD added this to the v3.1.x milestone Feb 7, 2023
yuwu9145 added a commit to yuwu9145/vuetify that referenced this issue Feb 18, 2023
@yuwu9145
fix(VCol): fix BreakPoints type
57a1b92 
fix vuetifyjs#16604
@yuwu9145 yuwu9145 mentioned this issue Feb 18, 2023
Merged
@ferferga ferferga mentioned this issue Feb 18, 2023
Merged
15 tasks
yuwu9145 added a commit to yuwu9145/vuetify that referenced this issue Feb 22, 2023
@yuwu9145
fix(VCol): fix BreakPoints type
239e4f5 
fix vuetifyjs#16604
yuwu9145 added a commit to yuwu9145/vuetify that referenced this issue Feb 22, 2023
@yuwu9145
fix(VCol): fix BreakPoints type
a0c71c7 
fix vuetifyjs#16604
yuwu9145 added a commit to yuwu9145/vuetify that referenced this issue Feb 22, 2023
@yuwu9145
fix(VCol): fix BreakPoints type
62919c5 
fix vuetifyjs#16604
yuwu9145 added a commit to yuwu9145/vuetify that referenced this issue Mar 6, 2023
@yuwu9145
fix(VCol): fix BreakPoints type
d9631c6 
fix vuetifyjs#16604
KaelWD added a commit that referenced this issue Mar 21, 2023
@yuwu9145 @KaelWD
fix(VGrid): fix breakpoints types (#16708)
e4d562f 
fixes #16604

Co-authored-by: Kael <kaelwd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuwu9145 yuwu9145

Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.1.x
Development

Successfully merging a pull request may close this issue.

fix(VGrid): fix breakpoints types yuwu9145/vuetify
3 participants
@yuwu9145 @ferferga @KaelWD