Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VGrid): fix breakpoints types #16708

Merged
merged 6 commits into from
Mar 21, 2023
Merged

fix(VGrid): fix breakpoints types #16708

merged 6 commits into from
Mar 21, 2023

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Feb 18, 2023

fix #16604

Description

resolves #16604

Markup:

<template>
  <v-app>
    <v-main>
      <v-row
        alignSm="end"
        alignMd="end"
        align-lg="end"
        alignXl="end"
        alignXxl="end"
        alignContent="start"
        alignContentSm="start"
        align-content-md="start"
        align-content-lg="start"
        alignContentXl="start"
        alignContentXxl="start"
        justify-sm="space-between"
        justifyMd="space-between"
        justify-lg="space-between"
        justify-xl="space-between"
        justify-xxl="space-between"
      >
        <v-col 
          cols="12"
          sm="7"
          md="7"
          lg="7"
          xl="7"
          xxl="7"
          offset-sm="7"
          offsetMd="7"
          offset-lg="7"
          offsetXl="7"
          offsetXxl="7"
          orderSm="7"
          orderMd="7"
          orderLg="7"
          orderXl="7"
          orderXxl="7"
        ></v-col>
      </v-row>
    </v-main>
  </v-app>
</template>

<script lang="ts">
import { defineComponent } from 'vue'
export default defineComponent({
})
</script>


@yuwu9145 yuwu9145 force-pushed the fix-16604 branch 3 times, most recently from e78f69e to b7f3349 Compare February 21, 2023 02:12
@yuwu9145 yuwu9145 marked this pull request as ready for review February 21, 2023 04:45
@yuwu9145 yuwu9145 force-pushed the fix-16604 branch 3 times, most recently from e2cc799 to c5799b5 Compare February 22, 2023 05:03
@johnleider
Copy link
Member

I think the script should be a separate PR. @KaelWD needs to chime in on this as well.

@yuwu9145
Copy link
Member Author

yuwu9145 commented Mar 1, 2023

@KaelWD I can easily separate the script part into an independent PR if you want

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VGrid Covers issues involving VContainer, VLayout, VFlex labels Mar 5, 2023
@johnleider johnleider requested a review from KaelWD March 5, 2023 15:56
@yuwu9145
Copy link
Member Author

yuwu9145 commented Mar 6, 2023

Script has been move to PR #16843

@@ -0,0 +1,3 @@
export const breakpoints = ['sm', 'md', 'lg', 'xl', 'xxl'] as const // no xs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to come up with a way to propagate this sizing information as part of the framework simply because of how many places it is used in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking on this, I felt the most natural place would be within the display composable. What do you think @vuetifyjs/core-team ?

Copy link
Member Author

@yuwu9145 yuwu9145 Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this change in display composable?

image

@yuwu9145
Copy link
Member Author

yuwu9145 commented Mar 10, 2023

To make feedback process smooth, I moved breakpoints to display composable.

I also did a local testing via yarn build & yarn link against the repo in the issue, type errors from VGrid disappears.

@yuwu9145 yuwu9145 marked this pull request as ready for review March 10, 2023 11:24
Copy link
Contributor

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaelWD KaelWD added this to the v3.1.x milestone Mar 21, 2023
@KaelWD KaelWD changed the title fix(VCol): fix BreakPoints type fix(VGrid): fix breakpoints types Mar 21, 2023
@KaelWD KaelWD merged commit e4d562f into vuetifyjs:master Mar 21, 2023
@yuwu9145 yuwu9145 deleted the fix-16604 branch March 21, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.1.2] No types for VGrid components' props
4 participants