Refactor ABI encoder #1723
Refactor ABI encoder #1723
Conversation
charles-cooper
force-pushed
the
abi_refactor
branch
3 times, most recently
from
a85571b
to
2eaf3d3
Compare
define types, utility functions
leaf bytes are encoded as-is (+ padding), tuples with child bytes are encoded <ofst> <len> <data>.
instead of storing just the pointers themselves.
destination should always be memory otherwise make_setter returns None.
make_return_stmt jumps out of the with statement, leaving the with variables on the stack (when they shouldn't be).
easier to reason about
by using make_setter for its typechecking side effects.
abi sizes are now in bytes.
The idea is that in a lot of cases (e.g. decoding calldata), we don't actually need to copy the data from the abi-encoded buffer into a destination buffer, but instead we can "leave it where it is" and instead just generate loader statements for the data.
and fixed arrays
(if it is not already)
charles-cooper
force-pushed
the
abi_refactor
branch
from
2eaf3d3
to
f8886fa
Compare
|
this is ready for a look over. there's still a lot to do (ultimately i want to replace our entire calling convention and event generation code with abi_encode/abi_decode and now it's just generating returndata with abi_encode) but it's at a good self-contained stage where we can review and move further work into another PR. note that |
charles-cooper
requested review from
fubuloubu,
jacqueswww and
iamdefinitelyahuman
|
requesting comments from @fubuloubu @jacqueswww and/or @iamdefinitelyahuman |
|
And note, by testing I meant for any functionality that's changed, which doesn't appear to be much (yet) |
no functionality has changed (theoretically) |
Co-Authored-By: Bryant Eisenbach <3859395+fubuloubu@users.noreply.github.com>
|
Merge on CI pass |
What I did
Refactor the ABI encoder/decoder so that the code is clearer and more extensible. This should make it easier to implement ABI-related features.
There's still a lot to do (ultimately I want to replace our entire calling convention and event generation code with abi_encode/abi_decode, for now it's just returndata with abi_encode) but it's at a good self-contained stage where we can review and move further work into another PR. Tote that abi_decode and lazy_abi_decode are unused right now but they will be useful in the future.
How I did it
See commit messages and inline comments
How to verify it
Tests pass
Description for the changelog
Refactor ABI encoder for return data.
Cute Animal Picture