Fix abi tuple return for lists #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_variable_offset expects the index to have a vyper type.
charles-cooper
requested review from
fubuloubu,
jacqueswww and
iamdefinitelyahuman
fubuloubu
approved these changes
Jan 24, 2020
iamdefinitelyahuman
approved these changes
Jan 25, 2020
|
Cool! |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1409. list-inside-tuple returns were mostly fixed in #1723 but this was a lingering bug. This also fixes #955 .
How I did it
add_variable_offsetexpects the index to have a vyper type.How to verify it
check that the example in #1409 compiles.
Description for the changelog
Fix returning of lists within tuples
Cute Animal Picture