-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Excessive Scoping Rules on Local Variables #2166
Remove Excessive Scoping Rules on Local Variables #2166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
+ Coverage 84.26% 85.22% +0.95%
==========================================
Files 83 83
Lines 8337 8330 -7
Branches 2012 2009 -3
==========================================
+ Hits 7025 7099 +74
+ Misses 809 731 -78
+ Partials 503 500 -3
Continue to review full report at Codecov.
|
Here https://vyper.readthedocs.io/en/latest/scoping-and-declarations.html?highlight=shadow#name-shadowing
I guess the reference to calldata should be removed given this merge? |
Yes! Can you submit a PR please? |
No idea how to do :) Also, about the return statement https://vyper.readthedocs.io/en/latest/statements.html?highlight=return#return, the guide states that all functions must end with it, but the compiler seems fine if no return is provided. |
fixes: #2127
Description for the changelog
No longer throws when a local variable has the same name as a global, due to the namespacing by
self.
Cute Animal Picture