Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift restriction on calldata variables shadowing storage variables #2226

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Lift a restriction preventing calldata variable names from shadowing storage variable names.

Related to #2166
Fixes #2219

How I did it

Remove the checks in context and parser subpackages.

How to verify it

Run tests.

Cute Animal Picture

image

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #2226 (6af6fa2) into master (3667bc5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
+ Coverage   85.32%   85.34%   +0.01%     
==========================================
  Files          84       84              
  Lines        8533     8528       -5     
  Branches     2064     2061       -3     
==========================================
- Hits         7281     7278       -3     
+ Misses        745      744       -1     
+ Partials      507      506       -1     
Impacted Files Coverage Δ
vyper/context/types/function.py 83.75% <ø> (-0.21%) ⬇️
...er/function_definitions/parse_external_function.py 97.82% <ø> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3667bc5...6af6fa2. Read the comment docs.

@fubuloubu fubuloubu merged commit cb06a06 into vyperlang:master Nov 27, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-calldata-shadow branch December 4, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calldata variables cannot shadow storage variables
3 participants