-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export the storage layout #2433
export the storage layout #2433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2433 +/- ##
==========================================
+ Coverage 84.62% 84.65% +0.02%
==========================================
Files 94 94
Lines 9423 9441 +18
Branches 2205 2207 +2
==========================================
+ Hits 7974 7992 +18
Misses 939 939
Partials 510 510
Continue to review full report at Codecov.
|
@@ -13,6 +13,7 @@ def test_combined_json_keys(tmp_path): | |||
"bytecode_runtime", | |||
"abi", | |||
"source_map", | |||
"storage_layout", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other ones are just layout
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why I did this lol but I used "layout" for the cli flag and "storage_layout" internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say just do one or the other
4124a43
to
f792c45
Compare
@fubuloubu I slightly modified some behavior in f792c45, could you take a look? I don't think it's a breaking change but it may deserve its own PR. |
f792c45
to
6d91720
Compare
I wouldn't call it a breaking change persay (more of an optimization), but definitely should be it's own PR |
6d91720
to
e40ec84
Compare
@fubuloubu I opened a followup PR for the optimization #2439 |
e40ec84
to
99a8961
Compare
What I did
Implement #1950
How I did it
How to verify it
Compile with
-f layout
Description for the changelog
Cute Animal Picture