Fix unused storage slots #2439
Merged
Fix unused storage slots #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2439 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 94 94
Lines 9273 9276 +3
Branches 2093 2094 +1
=======================================
+ Hits 7848 7851 +3
Misses 940 940
Partials 485 485
Continue to review full report at Codecov.
|
charles-cooper
force-pushed
the
fix/dup_storage_slots
branch
from
f792c45
to
87a15d1
Compare
|
Can you rebase on |
|
Sure. I'm not so sure anymore this is such a useful optimization tho. It only helps if there are more than 255 (storage variables + nonreentrant keys) |
this is not a semantic bug but an optimization bug since we allocate more slots than we actually need, leading to "holes" in the slot allocator -- slots which are allocated but unused.
charles-cooper
force-pushed
the
fix/dup_storage_slots
branch
from
87a15d1
to
488b55e
Compare
|
related: #2436 |
iamdefinitelyahuman
approved these changes
Sep 2, 2021
|
Alright, along with b5b6705 I feel pretty confident about this PR. |
fubuloubu
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Description for the changelog
fix: don't allocate slots for nonreentrant keys which appear multiple times.
Cute Animal Picture