-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unused storage slots #2439
Fix unused storage slots #2439
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2439 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 94 94
Lines 9273 9276 +3
Branches 2093 2094 +1
=======================================
+ Hits 7848 7851 +3
Misses 940 940
Partials 485 485
Continue to review full report at Codecov.
|
f792c45
to
87a15d1
Compare
Can you rebase on |
Sure. I'm not so sure anymore this is such a useful optimization tho. It only helps if there are more than 255 (storage variables + nonreentrant keys) |
this is not a semantic bug but an optimization bug since we allocate more slots than we actually need, leading to "holes" in the slot allocator -- slots which are allocated but unused.
87a15d1
to
488b55e
Compare
related: #2436 |
Alright, along with b5b6705 I feel pretty confident about this PR. |
What I did
How I did it
How to verify it
Description for the changelog
fix: don't allocate slots for nonreentrant keys which appear multiple times.
Cute Animal Picture