Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "nonreentrant" on view functions #2921

Merged
merged 3 commits into from
Jun 19, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 19, 2022

on view functions, the sstores are not issued, but the sload check is

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

image

on view functions, the sstores are not issued, but the sload check is
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #2921 (294ed3b) into master (4e38ec4) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
- Coverage   88.47%   88.46%   -0.02%     
==========================================
  Files          97       97              
  Lines       10613    10616       +3     
  Branches     2527     2528       +1     
==========================================
+ Hits         9390     9391       +1     
- Misses        770      771       +1     
- Partials      453      454       +1     
Impacted Files Coverage Δ
vyper/codegen/function_definitions/utils.py 80.00% <66.66%> (-20.00%) ⬇️
vyper/semantics/types/function.py 87.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e38ec4...294ed3b. Read the comment docs.

@charles-cooper charles-cooper marked this pull request as ready for review June 19, 2022 16:08
@charles-cooper charles-cooper requested a review from fubuloubu June 19, 2022 16:08
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

vyper/codegen/function_definitions/utils.py Show resolved Hide resolved
@charles-cooper
Copy link
Member Author

Needs tests

see 294ed3b

@charles-cooper charles-cooper requested a review from fubuloubu June 19, 2022 19:00
@charles-cooper charles-cooper enabled auto-merge (squash) June 19, 2022 19:44
@charles-cooper charles-cooper merged commit 6ae0eed into vyperlang:master Jun 19, 2022
@charles-cooper charles-cooper deleted the nonreentrant_view branch May 1, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants