feat[lang]!: make internal decorator optional

[charles-cooper]

What I did

per title

How I did it

How to verify it

updated a couple tests for it

Commit message

make `@internal` decorator optional. since functions can be imported
now, the `@internal` decorator could be confusing UX, since it is not
clear (without referencing docs) whether `@internal` means "hidden from
importers of this module", or "not included in the selector table". with
this commit, functions don't need a visibility marker, and are just
internal by default.

Description for the changelog

Cute Animal Picture

[cyberthirst]

could this be any problem wrt to integrity hash in archives?

[charles-cooper]

could this be any problem wrt to integrity hash in archives?

i don't think so, no. the integrity hash is based on source hash. so you can have multiple sources which compile to the same bytecode, but this is already the case (e.g. source code comments change hash but not bytecode)

[cyberthirst]

why do we allow @nonreentrant + @view? is it read-only reentrancy?

[cyberthirst]

why not remove

vyper/vyper/semantics/types/function.py

Lines 770 to 771 in 9c157c2

	# assert function_visibility is not None # mypy
	# assert state_mutability is not None # mypy

[cyberthirst]

contracts like this

def __init__():
    pass

will throw

 vyper.exceptions.FunctionDeclarationException: Constructor must be marked as `@deploy`, not `@internal`

which is a bit wierd

[cyberthirst]

did we update the docs to reflect this feature?

[charles-cooper]

did we update the docs to reflect this feature?

yes, in #3947

[charles-cooper]

contracts like this

def __init__():
    pass

will throw

 vyper.exceptions.FunctionDeclarationException: Constructor must be marked as `@deploy`, not `@internal`

which is a bit wierd

0a48a56

[charles-cooper]

why not remove

vyper/vyper/semantics/types/function.py

Lines 770 to 771 in 9c157c2

	# assert function_visibility is not None # mypy
	# assert state_mutability is not None # mypy

9f679b2

[charles-cooper]

why do we allow @nonreentrant + @view? is it read-only reentrancy?

yes, #2921

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (abf795a) to head (8b4a023).
Report is 55 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4040      +/-   ##
==========================================
- Coverage   91.12%   88.61%   -2.51%     
==========================================
  Files         106      106              
  Lines       15309    15307       -2     
  Branches     3366     3366              
==========================================
- Hits        13950    13564     -386     
- Misses        925     1234     +309     
- Partials      434      509      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.