-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]!: make internal decorator optional #4040
feat[lang]!: make internal decorator optional #4040
Conversation
the default is now internal.
could this be any problem wrt to integrity hash in archives? |
i don't think so, no. the integrity hash is based on source hash. so you can have multiple sources which compile to the same bytecode, but this is already the case (e.g. source code comments change hash but not bytecode) |
why do we allow |
why not remove vyper/vyper/semantics/types/function.py Lines 770 to 771 in 9c157c2
|
contracts like this
will throw
which is a bit wierd |
did we update the docs to reflect this feature? |
yes, in #3947 |
|
|
yes, #2921 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4040 +/- ##
==========================================
- Coverage 91.12% 88.61% -2.51%
==========================================
Files 106 106
Lines 15309 15307 -2
Branches 3366 3366
==========================================
- Hits 13950 13564 -386
- Misses 925 1234 +309
- Partials 434 509 +75 ☔ View full report in Codecov by Sentry. |
What I did
per title
How I did it
How to verify it
updated a couple tests for it
Commit message
Description for the changelog
Cute Animal Picture