-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[venom]: liveness analysis in some loops #3732
Merged
charles-cooper
merged 20 commits into
vyperlang:master
from
harkal:fix/liveness_fix_simple_loop_case
Jan 17, 2024
Merged
fix[venom]: liveness analysis in some loops #3732
charles-cooper
merged 20 commits into
vyperlang:master
from
harkal:fix/liveness_fix_simple_loop_case
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the functions handle the case there is no deploy instructions
* Converted algorithm to iterative * fixed a bug related to simple loops
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3732 +/- ##
==========================================
+ Coverage 84.18% 84.86% +0.68%
==========================================
Files 92 92
Lines 13143 13128 -15
Branches 2928 2927 -1
==========================================
+ Hits 11064 11141 +77
+ Misses 1659 1525 -134
- Partials 420 462 +42 ☔ View full report in Codecov by Sentry. |
charles-cooper
requested changes
Jan 17, 2024
- rename it to ir_node_to_venom - fix bb well-formedness for deploy ir - don't do deploy IR detection; rely on caller in CompilerData to call for both deploy and runtime IR - remove findIRnode, it's no longer needed
charles-cooper
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed a small issue with the calculation of liveness in the case of variables in simple loops.
How I did it
Refactored the liveness calculation algorithm to an iterative version over the recursive one. Along side some additional refactoring to make the code cleaner and easier to follow.
How to verify it
I added the test_liveness_simple_loop.py that failed without the fix
Commit message
Description for the changelog
Cute Animal Picture