Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more venom instructions #3733

Merged

Conversation

charles-cooper
Copy link
Member

What I did

depends on #3732

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c42b077) 84.83% compared to head (7b9b7ef) 84.78%.

Files Patch % Lines
vyper/venom/ir_node_to_venom.py 18.18% 7 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3733      +/-   ##
==========================================
- Coverage   84.83%   84.78%   -0.06%     
==========================================
  Files          92       92              
  Lines       13128    13137       +9     
  Branches     2927     2929       +2     
==========================================
+ Hits        11137    11138       +1     
- Misses       1529     1535       +6     
- Partials      462      464       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if @harkal can approve, but my approval is contingent on his for merging

@charles-cooper
Copy link
Member Author

Not sure if @harkal can approve, but my approval is contingent on his for merging

yep he can

- not
- ceil32
- select
- blockhash

improve some exception handling for missed cases
invoke/call/staticcall should not change the CFG!
@charles-cooper charles-cooper merged commit 4177745 into vyperlang:master Jan 18, 2024
84 checks passed
@charles-cooper charles-cooper deleted the feat/venom-instructions branch January 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants