-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify the params API #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, human-facing
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Discussed at 8 October meeting [minutes to be linked]. Agreed to merge when reviews complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
I think we got all reviews complete. Can I merge this? Or is there anything else actionable here? |
I got the ack from @wseltzer to merge. Done. |
SHA: bfa0a09 Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bfa0a09 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1. ("client_id", |provider|'s {{IdentityProviderConfig/clientId}}) | ||
1. ("nonce", |provider|'s {{IdentityProviderRequestOptions/nonce}}) | ||
1. ("account_id", |accountId|) | ||
1. ("disclosure_text_shown", |disclosureTextShown|) | ||
1. ("is_auto_selected", |isAutoSelected|) | ||
1. If |provider|'s {{IdentityProviderRequestOptions/params}} is not empty: | ||
1. Let |json| be the result of [=serializing a JavaScript value to a JSON string=] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbiesinger something that was brought to my attention while reviewing a different PR was that this algorithm can throw: that's unlikely and seems like a programming error, but seemed worth noting somewhere here what we should do when this throws.
Bug: w3c-fedid/custom-requests#2
Preview | Diff