Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the params API #661

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Specify the params API #661

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5ff1f3
Specify the params API
cbiesinger Oct 2, 2024
1840d56
Update spec/index.bs
cbiesinger Oct 3, 2024
4e432ab
any
cbiesinger Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@ dictionary IdentityProviderRequestOptions : IdentityProviderConfig {
USVString nonce;
DOMString loginHint;
DOMString domainHint;
record<USVString, any> params;
samuelgoto marked this conversation as resolved.
Show resolved Hide resolved
};
</xmp>

Expand Down Expand Up @@ -1198,12 +1199,17 @@ To <dfn>fetch an identity assertion</dfn> given a {{USVString}}
1. Let |tokenUrl| be the result of [=computing the manifest URL=] given |provider|,
|config|["{{IdentityProviderAPIConfig/id_assertion_endpoint}}"], and |globalObject|.
1. If |tokenUrl| is failure, return failure.
1. Let |requestBody| be the result of running [=urlencoded serializer=] with a list containing:
1. Let |list| be a list with the following entries:
1. ("client_id", |provider|'s {{IdentityProviderConfig/clientId}})
1. ("nonce", |provider|'s {{IdentityProviderRequestOptions/nonce}})
1. ("account_id", |accountId|)
1. ("disclosure_text_shown", |disclosureTextShown|)
1. ("is_auto_selected", |isAutoSelected|)
1. If |provider|'s {{IdentityProviderRequestOptions/params}} is not empty:
1. Let |json| be the result of [=serializing a JavaScript value to a JSON string=]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbiesinger something that was brought to my attention while reviewing a different PR was that this algorithm can throw: that's unlikely and seems like a programming error, but seemed worth noting somewhere here what we should do when this throws.

with |provider|'s {{IdentityProviderRequestOptions/params}}.
1. Append ("params", |json|) to |list|.
1. Let |requestBody| be the result of running [=urlencoded serializer=] with |list|.
1. Let |request| be a new <a spec=fetch for=/>request</a> as follows:

: [=request/url=]
Expand Down
Loading